ash: Animate changes in the uber tray.

ash/system/tray/system_tray.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray.h"
 
 #include "ash/shell.h"
 #include "ash/shell/panel_window.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/tray/tray_constants.h"
@@ skipping 40 matching lines @@
 const int kArrowHeight = 10;
 const int kArrowWidth = 20;
 const int kArrowPaddingFromRight = 20;
 
 const int kShadowOffset = 3;
 const int kShadowHeight = 3;
 
 const int kLeftPadding = 4;
 const int kBottomLineHeight = 1;
 
-const int kTrayIconHeight = 29;
-
 const SkColor kShadowColor = SkColorSetARGB(25, 0, 0, 0);
 
 const SkColor kTrayBackgroundAlpha = 100;
 const SkColor kTrayBackgroundHoverAlpha = 150;
 
-// Container for items in the tray. It makes sure the widget is updated
-// correctly when the visibility/size of the tray item changes.
-// TODO: setup animation.
-class TrayItemContainer : public views::View {
- public:
-  explicit TrayItemContainer(views::View* view) : child_(view) {
-    AddChildView(child_);
-    SetVisible(child_->visible());
-  }
-
-  virtual ~TrayItemContainer() {}
-
- private:
-  // Makes sure the widget relayouts after the size/visibility of the view
-  // changes.
-  void ApplyChange() {
-    // Forcing the widget to the new size is sufficient. The positing is taken
-    // care of by the layout manager (ShelfLayoutManager).
-    GetWidget()->SetSize(GetWidget()->GetContentsView()->GetPreferredSize());
-  }
-
-  // Overridden from views::View.
-  virtual void Layout() {
-    child_->SetBoundsRect(gfx::Rect(size()));
-  }
-
-  virtual gfx::Size GetPreferredSize() OVERRIDE {
-    gfx::Size size = child_->GetPreferredSize();
-    size.set_height(kTrayIconHeight);
-    return size;
-  }
-
-  virtual void ChildPreferredSizeChanged(views::View* child) OVERRIDE {
-    ApplyChange();
-  }
-
-  virtual void ChildVisibilityChanged(views::View* child) OVERRIDE {
-    if (visible() == child_->visible())
-      return;
-    SetVisible(child_->visible());
-    ApplyChange();
-  }
-
-  views::View* child_;
-
-  DISALLOW_COPY_AND_ASSIGN(TrayItemContainer);
-};
-
 // A view with some special behaviour for tray items in the popup:
 // - changes background color on hover.
-// - TODO: accessibility
 class TrayPopupItemContainer : public views::View {
  public:
   explicit TrayPopupItemContainer(views::View* view) : hover_(false) {
     set_notify_enter_exit_on_child(true);
     set_border(view->border() ? views::Border::CreateEmptyBorder(0, 0, 0, 0) :
                                 NULL);
     SetLayoutManager(new views::FillLayout);
     AddChildView(view);
   }
 
@@ skipping 363 matching lines @@
   if (popup_)
     popup_->CloseNow();
 }
 
 void SystemTray::AddTrayItem(SystemTrayItem* item) {
   items_.push_back(item);
 
   SystemTrayDelegate* delegate = Shell::GetInstance()->tray_delegate();
   views::View* tray_item = item->CreateTrayView(delegate->GetUserLoginStatus());
   if (tray_item) {
-    container_->AddChildViewAt(new TrayItemContainer(tray_item), 0);
+    container_->AddChildViewAt(tray_item, 0);
     PreferredSizeChanged();
   }
 }
 
 void SystemTray::RemoveTrayItem(SystemTrayItem* item) {
   NOTIMPLEMENTED();
 }
 
 void SystemTray::ShowDefaultView() {
   if (popup_) {
@@ skipping 38 matching lines @@
       ++it) {
     (*it)->DestroyTrayView();
   }
   container_->RemoveAllChildViews(true);
 
   for (std::vector<SystemTrayItem*>::iterator it = items_.begin();
       it != items_.end();
       ++it) {
     views::View* view = (*it)->CreateTrayView(login_status);
     if (view)
-      container_->AddChildViewAt(new TrayItemContainer(view), 0);
+      container_->AddChildViewAt(view, 0);
   }
   SetVisible(true);
   PreferredSizeChanged();
 }
 
 void SystemTray::SetPaintsBackground(
       bool value,
       internal::BackgroundAnimator::ChangeType change_type) {
   hide_background_animator_.SetPaintsBackground(value, change_type);
 }
@@ skipping 110 matching lines @@
       popup_->Hide();
     }
   }
   return base::EVENT_CONTINUE;
 }
 
 void SystemTray::DidProcessEvent(const base::NativeEvent& event) {
 }
 
 }  // namespace ash