Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: webkit/tools/test_shell/test_shell_webmimeregistry_impl.h

Issue 9969061: Changed TestShellWebMimeRegistryImpl to blacklist rather than whitelist containers and codecs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: s/conditional/blacklisted/ and header comment update. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_shell_webmimeregistry_impl.h
diff --git a/webkit/tools/test_shell/test_shell_webmimeregistry_impl.h b/webkit/tools/test_shell/test_shell_webmimeregistry_impl.h
index 2c8ad6cea0433508df3e83feab7902bafde61951..25e4f60bb89ba8c1565b571fb0378d2299b026e7 100644
--- a/webkit/tools/test_shell/test_shell_webmimeregistry_impl.h
+++ b/webkit/tools/test_shell/test_shell_webmimeregistry_impl.h
@@ -18,23 +18,25 @@ class TestShellWebMimeRegistryImpl
TestShellWebMimeRegistryImpl();
virtual ~TestShellWebMimeRegistryImpl();
- // Override to force that we only support ogg, vorbis and theora.
+ // Override to force that we only support types and codecs that are supported
+ // by all variations of Chromium.
//
// Media layout tests use canPlayType() to determine the test input files.
// Different flavours of Chromium support different codecs, which has an
- // impact on how canPlayType() behaves. Since Chromium's baselines are
- // generated against ogg/vorbis/theora content we need to lock down how
- // canPlayType() behaves when running layout tests.
+ // impact on how canPlayType() behaves. Since Chromium's baselines and
+ // expectations are generated against the common set of types, we need to
+ // prevent canPlayType() from indicating it supports other types when running
+ // layout tests.
virtual WebKit::WebMimeRegistry::SupportsType supportsMediaMIMEType(
const WebKit::WebString&, const WebKit::WebString&) OVERRIDE;
private:
- bool IsSupportedMediaMimeType(const std::string& mime_type);
- bool AreSupportedMediaCodecs(const std::vector<std::string>& codecs);
+ bool IsBlacklistedMediaMimeType(const std::string& mime_type);
+ bool HasBlacklistedMediaCodecs(const std::vector<std::string>& codecs);
typedef base::hash_set<std::string> MimeMappings;
- MimeMappings media_map_;
- MimeMappings codecs_map_;
+ MimeMappings blacklisted_media_map_;
+ MimeMappings blacklisted_codecs_map_;
DISALLOW_COPY_AND_ASSIGN(TestShellWebMimeRegistryImpl);
};

Powered by Google App Engine
This is Rietveld 408576698