Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 9969061: Changed TestShellWebMimeRegistryImpl to blacklist rather than whitelist containers and codecs. (Closed)

Created:
8 years, 8 months ago by ddorwin
Modified:
8 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Changed TestShellWebMimeRegistryImpl to blacklist rather than whitelist containers and codecs. New expected results for four tests need to be committed in WebKit. BUG=119667 TEST=WebM tests in LayoutTests/media/W3C/video/canPlayType/ now say "probably" or "maybe". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132463

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/conditional/blacklisted/ and header comment update. #

Total comments: 1

Patch Set 3 : Fixed spacing. #

Patch Set 4 : Rebased #

Patch Set 5 : fixed merge #

Total comments: 2

Patch Set 6 : Moved blacklist lists to mime_util. #

Total comments: 8

Patch Set 7 : Changed to output vector pointer #

Patch Set 8 : Using correct UNREFERENCED_PARAMETER macro #

Total comments: 6

Patch Set 9 : added clear() calls #

Total comments: 2

Patch Set 10 : renamed function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -47 lines) Patch
M net/base/mime_util.h View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M net/base/mime_util.cc View 1 2 3 4 5 6 7 8 9 7 chunks +55 lines, -14 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webmimeregistry_impl.h View 1 2 3 4 5 6 1 chunk +10 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
ddorwin
8 years, 8 months ago (2012-04-02 18:38:45 UTC) #1
scherkus (not reviewing)
http://codereview.chromium.org/9969061/diff/1/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc File webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc (right): http://codereview.chromium.org/9969061/diff/1/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc#newcode28 webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc:28: static const char* const conditional_media_types[] = { s/conditional/blacklisted/ ? ...
8 years, 8 months ago (2012-04-02 19:22:25 UTC) #2
ddorwin
On 2012/04/02 18:38:45, ddorwin wrote: Overrides: http://webk.it/82925
8 years, 8 months ago (2012-04-02 19:28:30 UTC) #3
ddorwin
http://codereview.chromium.org/9969061/diff/1/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc File webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc (right): http://codereview.chromium.org/9969061/diff/1/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc#newcode28 webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc:28: static const char* const conditional_media_types[] = { On 2012/04/02 ...
8 years, 8 months ago (2012-04-02 19:44:42 UTC) #4
scherkus (not reviewing)
LGTM w/ nit thanks! http://codereview.chromium.org/9969061/diff/2004/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc File webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc (right): http://codereview.chromium.org/9969061/diff/2004/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc#newcode47 webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc:47: "avc1", should be 2 space ...
8 years, 8 months ago (2012-04-02 19:54:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/9969061/7001
8 years, 8 months ago (2012-04-03 04:52:04 UTC) #6
commit-bot: I haz the power
Can't apply patch for file webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc. While running patch -p1 --forward --force; patching file webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc ...
8 years, 8 months ago (2012-04-03 04:52:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/9969061/4009
8 years, 8 months ago (2012-04-03 05:40:51 UTC) #8
commit-bot: I haz the power
Presubmit check for 9969061-4009 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-03 05:40:55 UTC) #9
ddorwin
Darin, please do an OWNERS review.
8 years, 8 months ago (2012-04-03 05:48:47 UTC) #10
darin (slow to review)
http://codereview.chromium.org/9969061/diff/4009/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc File webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc (right): http://codereview.chromium.org/9969061/diff/4009/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc#newcode27 webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc:27: static const char* const blacklisted_media_types[] = { seems unfortunate ...
8 years, 8 months ago (2012-04-03 23:01:13 UTC) #11
ddorwin
http://codereview.chromium.org/9969061/diff/4009/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc File webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc (right): http://codereview.chromium.org/9969061/diff/4009/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc#newcode27 webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc:27: static const char* const blacklisted_media_types[] = { On 2012/04/03 ...
8 years, 8 months ago (2012-04-04 20:59:18 UTC) #12
darin (slow to review)
On Wed, Apr 4, 2012 at 1:59 PM, <ddorwin@chromium.org> wrote: > > http://codereview.chromium.**org/9969061/diff/4009/webkit/** > tools/test_shell/test_shell_**webmimeregistry_impl.cc<http://codereview.chromium.org/9969061/diff/4009/webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc> ...
8 years, 8 months ago (2012-04-04 22:17:02 UTC) #13
ddorwin
I changed the CL to use mime_util, which required a little refactoring in mime_util. I ...
8 years, 8 months ago (2012-04-06 22:40:19 UTC) #14
qinmin
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc#newcode777 net/base/mime_util.cc:777: return proprietary_types; if we do this, does that mean ...
8 years, 8 months ago (2012-04-06 23:36:59 UTC) #15
ddorwin
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc#newcode777 net/base/mime_util.cc:777: return proprietary_types; On 2012/04/06 23:36:59, qinmin wrote: > if ...
8 years, 8 months ago (2012-04-07 02:40:41 UTC) #16
qinmin
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc#newcode777 net/base/mime_util.cc:777: return proprietary_types; Is it possible this will cause some ...
8 years, 8 months ago (2012-04-07 02:46:53 UTC) #17
ddorwin
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.cc#newcode777 net/base/mime_util.cc:777: return proprietary_types; On 2012/04/07 02:46:53, qinmin wrote: > Is ...
8 years, 8 months ago (2012-04-07 03:15:31 UTC) #18
qinmin
lgtm Thanks for the explanation, LGTM
8 years, 8 months ago (2012-04-07 03:38:05 UTC) #19
scherkus (not reviewing)
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.h File net/base/mime_util.h (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.h#newcode117 net/base/mime_util.h:117: NET_EXPORT std::vector<std::string> GetProprietaryMediaTypes(); can we pass in a std::vector<std::string> ...
8 years, 8 months ago (2012-04-10 21:22:17 UTC) #20
ddorwin
http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.h File net/base/mime_util.h (right): http://codereview.chromium.org/9969061/diff/17001/net/base/mime_util.h#newcode117 net/base/mime_util.h:117: NET_EXPORT std::vector<std::string> GetProprietaryMediaTypes(); On 2012/04/10 21:22:17, scherkus wrote: > ...
8 years, 8 months ago (2012-04-11 19:14:19 UTC) #21
scherkus (not reviewing)
LGTM w/ nits thanks ddorwin! http://codereview.chromium.org/9969061/diff/25002/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/9969061/diff/25002/net/base/mime_util.cc#newcode286 net/base/mime_util.cc:286: "avc1", de-indent by 2 ...
8 years, 8 months ago (2012-04-11 20:15:55 UTC) #22
ddorwin
Darin, please do an owners review of webkit/. I've addressed your previous feedback. Will, please ...
8 years, 8 months ago (2012-04-11 20:51:17 UTC) #23
willchan no longer on Chromium
+mmenke instead of me. Thanks Matt :)
8 years, 8 months ago (2012-04-12 10:43:23 UTC) #24
mmenke
Does seem a little odd to have layout test-specific information in net/, but then, I'd ...
8 years, 8 months ago (2012-04-12 16:36:23 UTC) #25
ddorwin
http://codereview.chromium.org/9969061/diff/29002/net/base/mime_util.h File net/base/mime_util.h (right): http://codereview.chromium.org/9969061/diff/29002/net/base/mime_util.h#newcode118 net/base/mime_util.h:118: NET_EXPORT void GetProprietaryMediaCodecs(std::vector<std::string>* codecs); On 2012/04/12 16:36:23, Matt Menke ...
8 years, 8 months ago (2012-04-12 16:56:10 UTC) #26
darin (slow to review)
LGTM
8 years, 8 months ago (2012-04-16 19:46:28 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/9969061/34001
8 years, 8 months ago (2012-04-16 19:52:08 UTC) #28
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 21:45:56 UTC) #29
Change committed as 132463

Powered by Google App Engine
This is Rietveld 408576698