Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/ui/browser_list_aura.cc

Issue 9968101: Close notification windows while message loop is still active (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_list.h" 5 #include "chrome/browser/ui/browser_list.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/notifications/notification_ui_manager.h"
9 11
10 // static 12 // static
11 void BrowserList::HandleAppExitingForPlatform() { 13 void BrowserList::HandleAppExitingForPlatform() {
14 // Close All non browser windows now. Those includes notifications
15 // and windows created by Ash (launcher, background, etc).
16 g_browser_process->notification_ui_manager()->CancelAll();
17 // TODO(oshima): Close all non browser windows here while
18 // the message loop is still alive.
12 #if defined(OS_CHROMEOS) 19 #if defined(OS_CHROMEOS)
13 if (!CommandLine::ForCurrentProcess()->HasSwitch( 20 if (!CommandLine::ForCurrentProcess()->HasSwitch(
14 switches::kDisableZeroBrowsersOpenForTests)) { 21 switches::kDisableZeroBrowsersOpenForTests)) {
15 // App is exiting, call EndKeepAlive() on behalf of Aura Shell. 22 // App is exiting, call EndKeepAlive() on behalf of Aura Shell.
16 BrowserList::EndKeepAlive(); 23 BrowserList::EndKeepAlive();
17 // Make sure we have notified the session manager that we are exiting. 24 // Make sure we have notified the session manager that we are exiting.
18 // This might be called from FastShutdown() or CloseAllBrowsers(), but not 25 // This might be called from FastShutdown() or CloseAllBrowsers(), but not
19 // if something prevents a browser from closing before SetTryingToQuit() 26 // if something prevents a browser from closing before SetTryingToQuit()
20 // gets called (e.g. browser->TabsNeedBeforeUnloadFired() is true). 27 // gets called (e.g. browser->TabsNeedBeforeUnloadFired() is true).
21 // NotifyAndTerminate does nothing if called more than once. 28 // NotifyAndTerminate does nothing if called more than once.
22 BrowserList::NotifyAndTerminate(true); 29 BrowserList::NotifyAndTerminate(true);
23 } 30 }
24 #endif // OS_CHROMEOS 31 #endif // OS_CHROMEOS
25 } 32 }
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/system/ash_system_tray_delegate.cc ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698