Browser Plugin: Renderer-side changes

content/renderer/pepper/pepper_plugin_delegate_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_DELEGATE_IMPL_H_
 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_DELEGATE_IMPL_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 79 matching lines @@
   // a PPAPI plugin. In this case, |*pepper_plugin_was_registered| will be set
   // to false and the caller may want to fall back on creating an NPAPI plugin.
   // the second is that the plugin failed to initialize. In this case,
   // |*pepper_plugin_was_registered| will be set to true and the caller should
   // not fall back on any other plugin types.
   CONTENT_EXPORT scoped_refptr<webkit::ppapi::PluginModule>
   CreatePepperPluginModule(
       const webkit::WebPluginInfo& webplugin_info,
       bool* pepper_plugin_was_registered);
 
+  CONTENT_EXPORT scoped_refptr<webkit::ppapi::PluginModule>

[jam, 2012/04/06 21:05:23]

nit: are you sure you need CONTENT_EXPORT (i.e. are you calling this from a unit
test? doesn't look like it, so no need to export)

[Fady Samuel, 2012/04/06 22:46:32]

Nope, remnant of an earlier revision of the code when I did somethings in chrome
instead of content. Removed.

+  CreateBrowserPluginModule(

[jam, 2012/04/06 21:05:23]

add comment for this function (see the rest of the file)

[Fady Samuel, 2012/04/06 22:46:32]

Done.

+      base::ProcessHandle process_handle,
+      const IPC::ChannelHandle& channel_handle);
+
   // Called by RenderView to tell us about painting events, these two functions
   // just correspond to the WillInitiatePaint, DidInitiatePaint and
   // DidFlushPaint hooks in RenderView.
   void ViewWillInitiatePaint();
   void ViewInitiatedPaint();
   void ViewFlushedPaint();
 
   // Called by RenderView to implement the corresponding function in its base
   // class RenderWidget (see that for more).
   webkit::ppapi::PluginInstance* GetBitmapForOptimizedPluginPaint(
@@ skipping 378 matching lines @@
 
   scoped_ptr<PepperDeviceEnumerationEventHandler>
       device_enumeration_event_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperPluginDelegateImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_DELEGATE_IMPL_H_