Remove Inspect Popup command from browser actions.

chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"
 
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
@@ skipping 54 matching lines @@
   const Extension* extension_;
 
   // The current profile. Weak.
   Profile* profile_;
 
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncUninstaller);
 };
 
-namespace extension_action_context_menu {
-
-class DevmodeObserver : public content::NotificationObserver {
- public:
-  DevmodeObserver(ExtensionActionContextMenu* menu,
-                             PrefService* service)
-      : menu_(menu), pref_service_(service) {
-    registrar_.Init(pref_service_);
-    registrar_.Add(prefs::kExtensionsUIDeveloperMode, this);
-  }
-  virtual ~DevmodeObserver() {}
-
-  void Observe(int type,
-               const content::NotificationSource& source,
-               const content::NotificationDetails& details) {
-    if (type == chrome::NOTIFICATION_PREF_CHANGED)
-      [menu_ updateInspectorItem];
-    else
-      NOTREACHED();
-  }
-
- private:
-  ExtensionActionContextMenu* menu_;
-  PrefService* pref_service_;
-  PrefChangeRegistrar registrar_;
-};
-
-class ProfileObserverBridge : public content::NotificationObserver {
- public:
-  ProfileObserverBridge(ExtensionActionContextMenu* owner,
-                        const Profile* profile)
-      : owner_(owner),
-        profile_(profile) {
-    registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
-                   content::Source<Profile>(profile));
-  }
-
-  ~ProfileObserverBridge() {}
-
-  // Overridden from content::NotificationObserver
-  void Observe(int type,
-               const content::NotificationSource& source,
-               const content::NotificationDetails& details) {
-    if (type == chrome::NOTIFICATION_PROFILE_DESTROYED &&
-        source == content::Source<Profile>(profile_)) {
-      [owner_ invalidateProfile];
-    }
-  }
-
- private:
-  ExtensionActionContextMenu* owner_;
-  const Profile* profile_;
-  content::NotificationRegistrar registrar_;
-};
-
-}  // namespace extension_action_context_menu
-
 @interface ExtensionActionContextMenu(Private)
 // Callback for the context menu items.
 - (void)dispatch:(id)menuItem;
 @end
 
 @implementation ExtensionActionContextMenu
 
 namespace {
 // Enum of menu item choices to their respective indices.
 // NOTE: You MUST keep this in sync with the |menuItems| NSArray below.
 enum {
   kExtensionContextName = 0,
   kExtensionContextOptions = 2,
   kExtensionContextDisable = 3,
   kExtensionContextUninstall = 4,
   kExtensionContextHide = 5,
   kExtensionContextManage = 7,
-  kExtensionContextInspect = 8
 };
 
 int CurrentTabId() {
   Browser* browser = BrowserList::GetLastActive();
   if(!browser)
     return -1;
   WebContents* contents = browser->GetSelectedWebContents();
   if (!contents)
     return -1;
   return ExtensionTabUtil::GetTabId(contents);
@@ skipping 36 matching lines @@
         if ([itemObj tag] == kExtensionContextHide &&
             !extension->browser_action()) {
           [itemObj setTarget:nil];  // Item is disabled.
           [itemObj setHidden:YES];  // Item is hidden.
         } else {
           [itemObj setTarget:self];
         }
       }
     }
 
-    NSString* inspectorTitle =
-        l10n_util::GetNSStringWithFixup(IDS_EXTENSION_ACTION_INSPECT_POPUP);
-    inspectorItem_.reset([[NSMenuItem alloc] initWithTitle:inspectorTitle
-                                                    action:@selector(dispatch:)
-                                             keyEquivalent:@""]);
-    [inspectorItem_.get() setTarget:self];
-    [inspectorItem_.get() setTag:kExtensionContextInspect];
-
-    PrefService* service = profile_->GetPrefs();
-    observer_.reset(
-        new extension_action_context_menu::DevmodeObserver(self, service));
-    profile_observer_.reset(
-        new extension_action_context_menu::ProfileObserverBridge(self,
-                                                                 profile));
-
-    [self updateInspectorItem];
     return self;
   }
   return nil;
 }
 
-- (void)updateInspectorItem {
-  PrefService* service = profile_->GetPrefs();
-  bool devmode = service->GetBoolean(prefs::kExtensionsUIDeveloperMode);
-  if (devmode) {
-    if ([self indexOfItem:inspectorItem_.get()] == -1)
-      [self addItem:inspectorItem_.get()];
-  } else {
-    if ([self indexOfItem:inspectorItem_.get()] != -1)
-      [self removeItem:inspectorItem_.get()];
-  }
-}
-
 - (void)dispatch:(id)menuItem {
   Browser* browser = BrowserList::FindBrowserWithProfile(profile_);
   if (!browser)
     return;
 
   NSMenuItem* item = (NSMenuItem*)menuItem;
   switch ([item tag]) {
     case kExtensionContextName: {
       GURL url(std::string(extension_urls::kGalleryBrowsePrefix) +
                std::string("/detail/") + extension_->id());
@@ skipping 22 matching lines @@
     }
     case kExtensionContextHide: {
       ExtensionService* extension_service = profile_->GetExtensionService();
       extension_service->SetBrowserActionVisibility(extension_, false);
       break;
     }
     case kExtensionContextManage: {
       browser->ShowExtensionsTab();
       break;
     }
-    case kExtensionContextInspect: {
-      BrowserWindowCocoa* window =
-          static_cast<BrowserWindowCocoa*>(browser->window());
-      ToolbarController* toolbarController =
-          [window->cocoa_controller() toolbarController];
-      LocationBarViewMac* locationBarView =
-          [toolbarController locationBarBridge];
-
-      NSPoint popupPoint = NSZeroPoint;
-      if (extension_->page_action() == action_) {
-        popupPoint = locationBarView->GetPageActionBubblePoint(action_);
-
-      } else if (extension_->browser_action() == action_) {
-        BrowserActionsController* controller =
-            [toolbarController browserActionsController];
-        popupPoint = [controller popupPointForBrowserAction:extension_];
-
-      } else {
-        NOTREACHED() << "action_ is not a page action or browser action?";
-      }
-
-      int tabId = CurrentTabId();
-      GURL url = action_->GetPopupUrl(tabId);
-      DCHECK(url.is_valid());
-      [ExtensionPopupController showURL:url
-                              inBrowser:BrowserList::GetLastActive()
-                             anchoredAt:popupPoint
-                          arrowLocation:info_bubble::kTopRight
-                                devMode:YES];
-      break;
-    }
     default:
       NOTREACHED();
       break;
   }
 }
 
 - (BOOL)validateMenuItem:(NSMenuItem*)menuItem {
-  if ([menuItem tag] == kExtensionContextInspect) {
-    // Disable 'Inspect popup' if there is no popup.
-    return action_ && action_->HasPopup(CurrentTabId());
-  } else if ([menuItem tag] == kExtensionContextOptions) {
+  if ([menuItem tag] == kExtensionContextOptions) {
     // Disable 'Options' if there are no options to set.
     return extension_->options_url().spec().length() > 0;
   }
   return YES;
 }
 
-- (void)invalidateProfile {
-  observer_.reset();
-  profile_ = NULL;
-}
-
 @end