Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 9968032: MIPS: RegExp: Add support for table-based character class code generation. (Closed)

Created:
8 years, 8 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

MIPS: RegExp: Add support for table-based character class code generation. Port r11189 (40c8cbd). Original commit message: RegExp: Add support for table-based character class code generation. This is performance neutral for all our tests, but a factor 6 faster for the Unicode based regexp in the new test (and much more compact code). BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated based on review recommendation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/mips/regexp-macro-assembler-mips.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kalmard
8 years, 8 months ago (2012-03-31 10:02:37 UTC) #1
Erik Corry
http://codereview.chromium.org/9968032/diff/1/src/mips/regexp-macro-assembler-mips.cc File src/mips/regexp-macro-assembler-mips.cc (right): http://codereview.chromium.org/9968032/diff/1/src/mips/regexp-macro-assembler-mips.cc#newcode518 src/mips/regexp-macro-assembler-mips.cc:518: __ lbu(a0, MemOperand(a0)); Since lbu supports memory-displacement operation should ...
8 years, 8 months ago (2012-03-31 20:10:15 UTC) #2
kalmard
Thanks for the review. http://codereview.chromium.org/9968032/diff/1/src/mips/regexp-macro-assembler-mips.cc File src/mips/regexp-macro-assembler-mips.cc (right): http://codereview.chromium.org/9968032/diff/1/src/mips/regexp-macro-assembler-mips.cc#newcode518 src/mips/regexp-macro-assembler-mips.cc:518: __ lbu(a0, MemOperand(a0)); On 2012/03/31 ...
8 years, 8 months ago (2012-04-02 09:43:28 UTC) #3
Erik Corry
LGTM committed as 11206, thanks.
8 years, 8 months ago (2012-04-02 11:28:08 UTC) #4
kalmard
8 years, 8 months ago (2012-04-05 08:17:48 UTC) #5
Thanks for landing. Closing.

Powered by Google App Engine
This is Rietveld 408576698