Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 9968030: Add an injectKeyEvent API to the Chromoting client plugin. (Closed)

Created:
8 years, 8 months ago by Wez
Modified:
8 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add an injectKeyEvent API to the Chromoting client plugin. The API allows a key (identified by USB-style identifier) event to be injected into the host by the web-application, to allow it to provide UI to inject key sequences that would not otherwise be possible on the client system (e.g. injecting Ctrl-Alt-Del from Windows, WinKey from CrOS, etc). BUG=105736, 120313 TEST=Will be manually testable by verifying that the Send Ctrl-Alt-Del button works, once implemented in a follow-up CL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130082

Patch Set 1 #

Patch Set 2 : Update API version. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M remoting/client/plugin/chromoting_instance.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 2 2 chunks +21 lines, -2 lines 0 comments Download
M remoting/webapp/client_plugin.js View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/webapp/client_plugin_async.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Wez
8 years, 8 months ago (2012-03-31 00:39:02 UTC) #1
Jamie
lgtm
8 years, 8 months ago (2012-03-31 00:49:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9968030/3001
8 years, 8 months ago (2012-03-31 01:07:27 UTC) #3
commit-bot: I haz the power
Can't apply patch for file remoting/client/plugin/chromoting_instance.cc. While running patch -p1 --forward --force; patching file remoting/client/plugin/chromoting_instance.cc ...
8 years, 8 months ago (2012-03-31 01:07:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9968030/5002
8 years, 8 months ago (2012-04-01 00:26:44 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-01 20:22:55 UTC) #6
Change committed as 130082

Powered by Google App Engine
This is Rietveld 408576698