chrome/browser/speech/extension_api/tts_extension_api_mac.mm - Issue 9967021: Uses a system-wide notion of isSpeaking in the Mac extension TTS api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api_mac.mm

Issue 9967021: Uses a system-wide notion of isSpeaking in the Mac extension TTS api. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised description for IsSpeaking based on comment. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/extension_api/tts_extension_api_mac.mm

diff --git a/chrome/browser/speech/extension_api/tts_extension_api_mac.mm b/chrome/browser/speech/extension_api/tts_extension_api_mac.mm

index 07d54e32928498a55268f826680e48c3b1a2afa0..b9934f89b8850685a45e7331b4d12eadefc0f835 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api_mac.mm

+++ b/chrome/browser/speech/extension_api/tts_extension_api_mac.mm

@@ -129,8 +129,7 @@ bool ExtensionTtsPlatformImplMac::StopSpeaking() {

}

bool ExtensionTtsPlatformImplMac::IsSpeaking() {

- // Note: this is OK even if speech_synthesizer_ is nil, it will return false.

- return [speech_synthesizer_ isSpeaking];

+ return [NSSpeechSynthesizer isAnyApplicationSpeaking];

}

bool ExtensionTtsPlatformImplMac::SendsEvent(TtsEventType event_type) {