Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: ppapi/cpp/output_traits.h

Issue 9965080: Change the cpp wrappers of audio input/video capture to use CompletionCallbackWithOutput. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More changes in response to Brett's comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/dev/video_capture_dev.cc ('k') | ppapi/examples/audio_input/audio_input.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/output_traits.h
diff --git a/ppapi/cpp/output_traits.h b/ppapi/cpp/output_traits.h
index 237b0bcf215083af2f17337624e18be31456453b..963f296cc2ad63758be8866543dd5276a67f3c0e 100644
--- a/ppapi/cpp/output_traits.h
+++ b/ppapi/cpp/output_traits.h
@@ -168,8 +168,8 @@ struct GenericVectorCallbackOutputTraits {
};
// Output traits for all vectors of resource types. It is implemented to pass
-// a PP_Resource* as an output parameter to the browser, and convert to the
-// given resource object type T when passing to the plugin.
+// a PP_ArrayOutput parameter to the browser, and convert the returned resources
+// to a vector of the given resource object type T when passing to the plugin.
//
// Note that this class is parameterized by the resource object, for example
// ResourceVectorCallbackOutputTraits<pp::FileRef>. This is used as a base
@@ -192,7 +192,7 @@ struct ResourceVectorCallbackOutputTraits {
// arrays of resources and arrays of POD (ints, structs, etc.) by inheriting
// from the appropriate base class depending on whether the given type derives
// from pp::Resource. This trick allows us to do this once rather than writing
-// specilalizations for every resource object type.
+// specializations for every resource object type.
template<typename T>
struct CallbackOutputTraits< std::vector<T> >
: public InheritIf<GenericVectorCallbackOutputTraits<T>,
« no previous file with comments | « ppapi/cpp/dev/video_capture_dev.cc ('k') | ppapi/examples/audio_input/audio_input.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698