- Add a class index to the classes.

vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/freelist.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/visitor.h"
@@ skipping 13 matching lines @@
   }
   // Validate that the class_ field is sensible.
   RawClass* raw_class = ptr()->class_;
   ASSERT(raw_class->IsHeapObject());
   RawClass* raw_class_class = raw_class->ptr()->class_;
   ASSERT(raw_class_class->IsHeapObject());
   ASSERT(raw_class_class->ptr()->instance_kind_ == kClass);
 
   // Validate that the tags_ field is sensible.
   intptr_t tags = ptr()->tags_;
-  ASSERT((tags & 0xffff00f0) == 0);
+  ASSERT((tags & 0x000000f0) == 0);

[siva, 2012/04/30 23:47:20]

We could add an assertion here that the class index is valid,
i.e the index points to a class and the class is sensible
(same checks as above which will go away when we remove the
class_ field).

[Ivan Posva, 2012/05/01 15:11:17]

Will do: See https://chromiumcodereview.appspot.com/10271032

 }
 
 
 intptr_t RawObject::SizeFromClass() const {
   NoHandleScope no_handles(Isolate::Current());
 
   // Only reasonable to be called on heap objects.
   ASSERT(IsHeapObject());
 
   RawClass* raw_class = ptr()->class_;
@@ skipping 648 matching lines @@
 intptr_t RawJSRegExp::VisitJSRegExpPointers(RawJSRegExp* raw_obj,
                                             ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   intptr_t length = Smi::Value(raw_obj->ptr()->data_length_);
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return JSRegExp::InstanceSize(length);
 }
 
 }  // namespace dart