Deprecate chrome.extension.sendRequest in favor of sendMessage, with a safer

chrome/renderer/resources/extensions/event.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
   var eventBindingsNatives = requireNative('event_bindings');
   var AttachEvent = eventBindingsNatives.AttachEvent;
   var DetachEvent = eventBindingsNatives.DetachEvent;
   var Print = eventBindingsNatives.Print;
 
   var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
@@ skipping 177 matching lines @@
   // Dispatches this event object to all listeners, passing all supplied
   // arguments to this function each listener.
   chrome.Event.prototype.dispatch = function(varargs) {
     if (!this.eventOptions_.supportsListeners)
       throw new Error("This event does not support listeners.");
     var args = Array.prototype.slice.call(arguments);
     var validationErrors = this.validate_(args);
     if (validationErrors) {
       return validationErrors;
     }
+    var retvals = [];
     for (var i = 0; i < this.listeners_.length; i++) {
       try {
-        this.listeners_[i].apply(null, args);
+        var retval = this.listeners_[i].apply(null, args);
+        if (retval !== undefined)
+          retvals.push(retval);
       } catch (e) {
         console.error("Error in event handler for '" + this.eventName_ +
                       "': " + e.stack);
       }
     }
+    if (retvals.length)
+      return retvals;

[Matt Perry, 2012/03/30 05:41:39]

This conflicts with 'return validationErrors' above. If I knew which caller
needed it, I could return an object that contains either validationErrors or
retvals so that callers can distinguish the two.

   };
 
   // Attaches this event object to its name.  Only one object can have a given
   // name.
   chrome.Event.prototype.attach_ = function() {
     AttachEvent(this.eventName_);
     allAttachedEvents[allAttachedEvents.length] = this;
     if (!this.eventName_)
       return;
 
@@ skipping 86 matching lines @@
     for (var i = 0; i < allAttachedEvents.length; ++i) {
       var event = allAttachedEvents[i];
       if (event)
         event.detach_(false);
     }
   };
 
   chromeHidden.dispatchError = function(msg) {
     console.error(msg);
   };