Introduces an additional extension loader that load extra extensions based on per-extension json fi…

chrome/common/chrome_paths.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CHROME_PATHS_H__
 #define CHROME_COMMON_CHROME_PATHS_H__
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 36 matching lines @@
   DIR_MANAGED_PREFS,            // Directory that stores the managed prefs plist
                                 // files for the current user.
 #endif
 #if defined(OS_CHROMEOS) || defined(OS_MACOSX)
   DIR_USER_EXTERNAL_EXTENSIONS,  // Directory for per-user external extensions
                                  // on Chrome Mac.  On Chrome OS, this path is
                                  // used for OEM customization.
                                  // Getting this path does not create it.
 #endif
 
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+  DIR_STANDALONE_EXTERNAL_EXTENSIONS,  // Directory for 'per-extension'
+                                       // definition manifest files that
+                                       // describe extensions which are to be
+                                       // installed when chrome is run.

[Finnur, 2012/04/25 13:33:45]

OK, this is an improvement, but I think we can still improve on it. You should
probably name this variable after the path 
that it identifies, and not the purpose for which you want to use it. I suggest:
DIR_EXTERNAL_EXTENSIONS_LINUX_USER_SHARE, or something to that effect.

Same goes for the comment. 

"The /usr/share/ directory containing the <extension id>.json files that list
what extensions to install. Getting this path does not create it."

[Alexandre Abreu, 2012/04/25 15:31:05]

mmh, I am really not too sure about that one. Although /usr/share seems like a
reasonable path
it is really sort of an implementation detail. I am not too fond of naming
something based on the
"theoretical" value that it has a given moment in time or even the OS the it is
current associated
to.

[Finnur, 2012/04/25 16:11:27]

OK, fine.

How about this comment then?

"The directory containing the <extension id>.json files that list what
extensions to install. Getting this path does not create it."

+#endif
   DIR_EXTERNAL_EXTENSIONS,      // Directory where installer places .crx files.
 
   DIR_DEFAULT_APPS,             // Directory where installer places .crx files
                                 // to be installed when chrome is first run.
   DIR_PEPPER_FLASH_PLUGIN,      // Directory to the Pepper Flash plugin,
                                 // containing the plugin and the manifest.
   FILE_RESOURCE_MODULE,         // Full path and filename of the module that
                                 // contains embedded resources (version,
                                 // strings, images, etc.).
   FILE_LOCAL_STATE,             // Path and filename to the file in which
@@ skipping 32 matching lines @@
 
   PATH_END
 };
 
 // Call once to register the provider for the path keys defined above.
 void RegisterPathProvider();
 
 }  // namespace chrome
 
 #endif  // CHROME_COMMON_CHROME_PATHS_H__