Introduces an additional extension loader that load extra extensions based on per-extension json fi…

chrome/browser/extensions/external_filesystem_extension_loader_linux.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTERNAL_FILESYSTEM_EXTENSION_LOADER_LINUX_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTERNAL_FILESYSTEM_EXTENSION_LOADER_LINUX_H_
+#pragma once
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/extensions/external_extension_loader.h"
+
+class ExternalFilesystemExtensionLoader : public ExternalExtensionLoader {

[Finnur, 2012/04/25 13:33:45]

Classes need class-level documentation. Doesn't have to be long, just a couple
of sentences that describe what they do.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+ public:
+  // |base_path_key| is the directory containing the per-extension description
+  // json files.  Relative file paths to extension files are resolved relative
+  // to this path.

[Finnur, 2012/04/25 13:33:45]

Suggest: |base_path_id| is the resource id of the base path containing the json
description of which extensions to load. File paths to extension files are
resolved relative to this path.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+  explicit ExternalFilesystemExtensionLoader(int base_path_key);

[Finnur, 2012/04/25 13:33:45]

Can you rename this to |base_path_id|?

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+
+  virtual const FilePath GetBaseCrxFilePath() OVERRIDE;
+
+ protected:
+  virtual void StartLoading() OVERRIDE;
+
+ private:
+  friend class base::RefCountedThreadSafe<ExternalExtensionLoader>;
+
+  virtual ~ExternalFilesystemExtensionLoader();
+
+  void LoadOnFileThread();

[Finnur, 2012/04/25 13:33:45]

This should be documented also.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+
+  // See the constructor's base_path_key.

[Finnur, 2012/04/25 13:33:45]

Suggest: The resource id of the base path containing the json file containing
which extensions to load.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+  int base_path_key_;

[Finnur, 2012/04/25 13:33:45]

Same here: base_path_id.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+
+  // Concrete path corresponding to the base_path_key_.

[Finnur, 2012/04/25 13:33:45]

Suggest: The path containing the json file containing which extensions to load.

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+  FilePath extension_base_path_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExternalFilesystemExtensionLoader);
+};
+
+#endif

[Finnur, 2012/04/25 13:33:45]

This is missing the
 // CHROME_BROWSER_EXTENSIONS_EXTERNAL_FILESYSTEM_EXTENSION_LOADER_LINUX_H_

[Alexandre Abreu, 2012/04/25 15:31:05]

Done.

+