Introduces an additional extension loader that load extra extensions based on per-extension json fi…

chrome/browser/extensions/external_extension_provider_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_extension_provider_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 21 matching lines @@
 #endif
 
 #if !defined(OS_CHROMEOS)
 #include "chrome/browser/extensions/default_apps.h"
 #endif
 
 #if defined(OS_WIN)
 #include "chrome/browser/extensions/external_registry_extension_loader_win.h"
 #endif
 
+#if defined(OS_LINUX)

[Sam Kerner (Chrome), 2012/04/13 19:35:13]

You only use this include on non-chrome os linux, so how about:

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

[Alexandre Abreu, 2012/04/13 21:52:38]

Done.

+#include "chrome/browser/extensions/external_filesystem_extension_loader_linux.h"

[Sam Kerner (Chrome), 2012/04/13 19:35:13]

Includes should be in alphabetical order, so this goes before
external_registry_extension_loader_win.h .

[Alexandre Abreu, 2012/04/13 21:52:38]

Done.

+#endif
+
 using content::BrowserThread;
 
 // Constants for keeping track of extension preferences in a dictionary.
 const char ExternalExtensionProviderImpl::kExternalCrx[] = "external_crx";
 const char ExternalExtensionProviderImpl::kExternalVersion[] =
     "external_version";
 const char ExternalExtensionProviderImpl::kExternalUpdateUrl[] =
     "external_update_url";
 const char ExternalExtensionProviderImpl::kSupportedLocales[] =
     "supported_locales";
@@ skipping 296 matching lines @@
 #if defined(OS_WIN)
   provider_list->push_back(
       linked_ptr<ExternalExtensionProviderInterface>(
           new ExternalExtensionProviderImpl(
               service,
               new ExternalRegistryExtensionLoader,
               Extension::EXTERNAL_REGISTRY,
               Extension::INVALID,
               Extension::NO_FLAGS)));
 #endif
+
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+  provider_list->push_back(
+      linked_ptr<ExternalExtensionProviderInterface>(
+          new ExternalExtensionProviderImpl(
+              service,

[Sam Kerner (Chrome), 2012/04/13 19:35:13]

Consider passing in the path constant to the constructor of
ExternalFilesystemExtensionLoader().  

[Alexandre Abreu, 2012/04/13 21:52:38]

Done.

+              new ExternalFilesystemExtensionLoader,
+              Extension::EXTERNAL_PREF,
+              Extension::EXTERNAL_PREF_DOWNLOAD,
+              Extension::NO_FLAGS)));
+#endif
+
   provider_list->push_back(
       linked_ptr<ExternalExtensionProviderInterface>(
           new ExternalExtensionProviderImpl(
               service,
               new ExternalPolicyExtensionLoader(profile),
               Extension::INVALID,
               Extension::EXTERNAL_POLICY_DOWNLOAD,
               Extension::NO_FLAGS)));
 
 #if !defined(OS_CHROMEOS)
@@ skipping 21 matching lines @@
         linked_ptr<ExternalExtensionProviderInterface>(
           new ExternalExtensionProviderImpl(
               service,
               connector->GetAppPackUpdater()->CreateExternalExtensionLoader(),
               Extension::EXTERNAL_PREF,
               Extension::INVALID,
               Extension::NO_FLAGS)));
   }
 #endif
 }