Build and push chrome.pak for ui_unittests on Android.

Build and push chrome.pak for ui_unittests on Android.

BUG=None
TEST=build/android/run_tests.py -s out/Release/ui_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130547

[John Grabowski, 2012-04-03 23:07:52]

LGTM

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp
File build/all_android.gyp (right):

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp#newcode45
build/all_android.gyp:45: '../chrome/chrome_resources.gyp:packed_resources',
add comment that  these are needed for ui_unittests

http://codereview.chromium.org/9963086/diff/1009/build/android/test_package_e...
File build/android/test_package_executable.py (right):

http://codereview.chromium.org/9963086/diff/1009/build/android/test_package_e...
build/android/test_package_executable.py:157:
self.adb.PushIfNeeded(self.test_suite_dirname + '/chrome.pak',
comment which test suite these are for.
only push them if the test suite is ui_unitttests, not always.

[Yaron, 2012-04-03 23:17:16]

lgtm

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp
File build/all_android.gyp (right):

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp#newcode45
build/all_android.gyp:45: '../chrome/chrome_resources.gyp:packed_resources',
On 2012/04/03 23:07:53, John Grabowski wrote:
> add comment that  these are needed for ui_unittests

Alternatively, consider adding it as a dep for ui_unittests. If not, there
should also be a TODO about putting this in the right place. I.e. I suspect the
android build has this as a build reuirement for content or content_shell

[Xianzhu, 2012-04-04 00:13:48]

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp
File build/all_android.gyp (right):

http://codereview.chromium.org/9963086/diff/1009/build/all_android.gyp#newcode45
build/all_android.gyp:45: '../chrome/chrome_resources.gyp:packed_resources',
Added comments and a TODO.

On 2012/04/03 23:17:16, Yaron wrote:
> On 2012/04/03 23:07:53, John Grabowski wrote:
> > add comment that  these are needed for ui_unittests
> 
> Alternatively, consider adding it as a dep for ui_unittests. If not, there
> should also be a TODO about putting this in the right place. I.e. I suspect
the
> android build has this as a build reuirement for content or content_shell

http://codereview.chromium.org/9963086/diff/1009/build/android/test_package_e...
File build/android/test_package_executable.py (right):

http://codereview.chromium.org/9963086/diff/1009/build/android/test_package_e...
build/android/test_package_executable.py:157:
self.adb.PushIfNeeded(self.test_suite_dirname + '/chrome.pak',
On 2012/04/03 23:07:53, John Grabowski wrote:
> comment which test suite these are for.
> only push them if the test suite is ui_unitttests, not always.

Done.

[commit-bot: I haz the power, 2012-04-04 00:17:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9963086/4010

[commit-bot: I haz the power, 2012-04-04 03:03:06]

Change committed as 130547