ash: Remap Command on Apple keyboards to Control [2/2]

ash: Remap Command on Apple keyboards to Control [2/2]

This is yusukes's http://codereview.chromium.org/9854025/
with my review comments applied.

chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc:

* Every time when a new device is added, notify the name of
  the device to KeyRewriter.
* Listens to XI_KeyPress and XI_KeyRelease events to the X
  root window, and notify the device ID of the event to
  KeyRewriter so that the rewriter could know the source of
  the next KeyPress/KeyRelease Core event.

Note that it's not possible to monitor both XI_KeyPress and
core KeyPress events for a single X window. For example, if
we monitor XI_KeyPress events in aura::RootWindowHostLinux
(by calling XISelectEvents() for the root Aura window,
xwindow_), it becomes impossible to receive KeyPress core
events for |xwindow_| in RootWindowHostLinux. It's also
impossible to convert XI_KeyPress into core KeyPress. That
is the reason why xinput_hierarchy_changed_event_listener.cc
is used to monitor XI_KeyPress/Release events.

chrome/browser/ui/views/ash/key_rewriter.cc:

* Rewrites Command key press on an Apple keyboard to Control
  key press, regardless of the user preference for remapping
  modifier keys.

Part 1 of 2 (Ash part): http://codereview.chromium.org/9838010/

BUG=121012
TEST=manual
TBR=sky

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130037

[Daniel Erat, 2012-03-31 01:25:23]

I'm not sure of the best way to review this.

http://codereview.chromium.org/9854025/ is the original change.  I uploaded it
here as patch set 1, and then uploaded my changes on top of it as patch set 2.

[Emmanuel Saint-loubert-Bié, 2012-03-31 01:59:17]

lgtm

[commit-bot: I haz the power, 2012-03-31 02:03:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/9963027/2001

[commit-bot: I haz the power, 2012-03-31 02:03:33]

Presubmit check for 9963027-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/aura

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Daniel Erat, 2012-03-31 02:05:27]

TBR-ing sky@ for ui/aura approval based on earlier IM conversation describing
the changes to aura::Event.

[commit-bot: I haz the power, 2012-03-31 02:05:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/9963027/2001

[commit-bot: I haz the power, 2012-03-31 03:52:58]

Change committed as 130037