Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9960071: TabContents -> WebContentsImpl, part 3. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 3. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6125 lines) Patch
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_error_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/tab_contents/debug_urls.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/browser/tab_contents/debug_urls.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/tab_contents/drag_utils_gtk.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/browser/tab_contents/drag_utils_gtk.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/tab_contents/interstitial_page_impl.h View 1 chunk +0 lines, -198 lines 0 comments Download
D content/browser/tab_contents/interstitial_page_impl.cc View 1 chunk +0 lines, -750 lines 0 comments Download
D content/browser/tab_contents/navigation_controller_impl.h View 1 chunk +0 lines, -332 lines 0 comments Download
D content/browser/tab_contents/navigation_controller_impl.cc View 1 chunk +0 lines, -1441 lines 0 comments Download
D content/browser/tab_contents/navigation_controller_impl_unittest.cc View 1 chunk +0 lines, -2592 lines 0 comments Download
D content/browser/tab_contents/navigation_entry_impl.h View 1 chunk +0 lines, -217 lines 0 comments Download
D content/browser/tab_contents/navigation_entry_impl.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D content/browser/tab_contents/navigation_entry_impl_unittest.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/debug_urls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/debug_urls.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/drag_utils_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/drag_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/interstitial_page_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/interstitial_page_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/navigation_controller_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/navigation_controller_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/web_contents/navigation_entry_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/web_contents/navigation_entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/web_contents/navigation_entry_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +10 lines, -10 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-10 19:02:53 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-10 19:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9960071/1
8 years, 8 months ago (2012-04-10 19:44:19 UTC) #3
commit-bot: I haz the power
Change committed as 131634
8 years, 8 months ago (2012-04-10 21:26:39 UTC) #4
amandasmith0321
4 years, 6 months ago (2016-06-24 07:18:31 UTC) #5
Message was sent while issue was closed. 
On 2012/04/10 19:17:09, jam wrote:
> lgtm

Powered by Google App Engine
This is Rietveld 408576698