Issue 9960058: ipc: don't treat replies with the unblock flag set as regular messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9960058: ipc: don't treat replies with the unblock flag set as regular messages (Closed)

Created:
8 years, 8 months ago by piman

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, Josh Horwich

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ipc: don't treat replies with the unblock flag set as regular messages Old behavior would test should_unblock() before is_reply() so if both were set but TryToUnblockListener wouldn't return true (the corresponding Send isn't on top of the stack), it would queue the message as to be dispatched. This restores the correct order. BUG=122443 TEST=ipc_tests, in particular ReentrantReply Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131617

Patch Set 1 #

Patch Set 2 : git try #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -4 lines)			Patch
M	ipc/ipc_sync_channel.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View	1	1 chunk	+114 lines, -0 lines	0 comments	Download
M	ipc/ipc_sync_message_unittest.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9960058/4002

8 years, 8 months ago (2012-04-10 18:19:00 UTC) #3

Change committed as 131617

Expand Messages | Collapse Messages