Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc

Issue 9959130: [Web Intents] Display throbber when loading inline disposition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc
diff --git a/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc b/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc
index 177c6c97b8b77287a92f93aabd195659f52bf0be..eb2fcaead9f18fbc04ca960b34b1117e6f1e3cf3 100644
--- a/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc
+++ b/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc
@@ -5,10 +5,13 @@
#include "chrome/browser/ui/intents/web_intent_inline_disposition_delegate.h"
#include "base/logging.h"
+#include "chrome/browser/ui/intents/web_intent_picker.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
-WebIntentInlineDispositionDelegate::WebIntentInlineDispositionDelegate() {
+WebIntentInlineDispositionDelegate::WebIntentInlineDispositionDelegate(
+ WebIntentPicker* picker)
+ : picker_(picker) {
}
WebIntentInlineDispositionDelegate::~WebIntentInlineDispositionDelegate() {
@@ -38,3 +41,11 @@ content::WebContents* WebIntentInlineDispositionDelegate::OpenURLFromTab(
return source;
}
+
+void WebIntentInlineDispositionDelegate::LoadingStateChanged(
+ content::WebContents* source) {
+ if (!source->IsLoading()) {
James Hawkins 2012/04/11 18:05:46 Optional nit: Save a line by removing braces.
binji 2012/04/12 17:48:49 Done.
+ picker_->OnInlineDispositionWebContentsLoaded(source);
+ }
+}
+

Powered by Google App Engine
This is Rietveld 408576698