Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9959130: [Web Intents] Display throbber when loading inline disposition. (Closed)

Created:
8 years, 8 months ago by binji
Modified:
8 years, 8 months ago
Reviewers:
James Hawkins, sky
CC:
chromium-reviews
Visibility:
Public.

Description

[Web Intents] Display throbber when loading inline disposition. BUG=112615 TEST=none TBR=sail@chromium.org TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132490

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : fix unit_tests #

Total comments: 10

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -83 lines) Patch
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate.h View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate_unittest.cc View 1 2 4 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 2 3 19 chunks +228 lines, -78 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
binji
sheriff today and tomorrow, can't really work on this... Still need to fix "Add to ...
8 years, 8 months ago (2012-04-04 20:59:04 UTC) #1
James Hawkins
http://codereview.chromium.org/9959130/diff/6/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc File chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc (right): http://codereview.chromium.org/9959130/diff/6/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc#newcode47 chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc:47: if (!source->IsLoading()) { Optional nit: Save a line by ...
8 years, 8 months ago (2012-04-11 18:05:46 UTC) #2
James Hawkins
Sorry man, forgot to push the publish button. LGTM with nits.
8 years, 8 months ago (2012-04-11 18:06:07 UTC) #3
binji
http://codereview.chromium.org/9959130/diff/6/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc File chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc (right): http://codereview.chromium.org/9959130/diff/6/chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc#newcode47 chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc:47: if (!source->IsLoading()) { On 2012/04/11 18:05:46, James Hawkins wrote: ...
8 years, 8 months ago (2012-04-12 17:48:49 UTC) #4
James Hawkins
SLGTM if you were waiting for that.
8 years, 8 months ago (2012-04-13 02:21:34 UTC) #5
binji
+sky for views OWNER. Please see http://code.google.com/p/chromium/issues/detail?id=112615#c5 for a screenshot.
8 years, 8 months ago (2012-04-13 20:24:10 UTC) #6
sky
http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc File chrome/browser/ui/views/web_intent_picker_views.cc (right): http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc#newcode141 chrome/browser/ui/views/web_intent_picker_views.cc:141: ~ThrobberNativeTextButton(); virtual http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc#newcode173 chrome/browser/ui/views/web_intent_picker_views.cc:173: base::Time start_time_; Use TimeTicks. http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc#newcode177 ...
8 years, 8 months ago (2012-04-13 21:36:16 UTC) #7
binji
http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc File chrome/browser/ui/views/web_intent_picker_views.cc (right): http://codereview.chromium.org/9959130/diff/14001/chrome/browser/ui/views/web_intent_picker_views.cc#newcode141 chrome/browser/ui/views/web_intent_picker_views.cc:141: ~ThrobberNativeTextButton(); On 2012/04/13 21:36:16, sky wrote: > virtual Done. ...
8 years, 8 months ago (2012-04-13 22:27:32 UTC) #8
sky
LGTM
8 years, 8 months ago (2012-04-13 22:49:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9959130/22001
8 years, 8 months ago (2012-04-16 19:44:44 UTC) #10
commit-bot: I haz the power
Try job failure for 9959130-22001 (retry) on win_rel for step "update". It's a second try, ...
8 years, 8 months ago (2012-04-16 19:48:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9959130/29003
8 years, 8 months ago (2012-04-16 22:44:48 UTC) #12
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 00:29:10 UTC) #13 
Change committed as 132490

Powered by Google App Engine
This is Rietveld 408576698