Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 9959116: Add support for not compiling in chrome/browser/background. (Closed)

Created:
8 years, 8 months ago by Jesse Greenwald
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for not compiling in chrome/browser/background. BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131037

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M build/common.gypi View 1 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jesse Greenwald
mirandac: chrome/browser/profiles atwilson: everything else Thanks,
8 years, 8 months ago (2012-04-03 20:46:47 UTC) #1
Andrew T Wilson (Slow)
Code LGTM assuming trybots pass - I'm surprised you don't get link errors if you ...
8 years, 8 months ago (2012-04-04 01:13:54 UTC) #2
Miranda Callahan
On 2012/04/04 01:13:54, Andrew T Wilson wrote: > Code LGTM assuming trybots pass - I'm ...
8 years, 8 months ago (2012-04-04 14:27:23 UTC) #3
Jesse Greenwald
atwilson - we've been removing quite a bit of code for the Android code via ...
8 years, 8 months ago (2012-04-04 20:16:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9959116/1
8 years, 8 months ago (2012-04-04 20:18:22 UTC) #5
commit-bot: I haz the power
Try job failure for 9959116-1 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 8 months ago (2012-04-05 01:46:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9959116/1
8 years, 8 months ago (2012-04-05 15:16:16 UTC) #7
commit-bot: I haz the power
Can't apply patch for file chrome/browser/profiles/profile_dependency_manager.cc. While running patch -p1 --forward --force; patching file chrome/browser/profiles/profile_dependency_manager.cc ...
8 years, 8 months ago (2012-04-05 19:53:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9959116/15003
8 years, 8 months ago (2012-04-05 20:24:54 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-05 22:53:03 UTC) #10
Change committed as 131037

Powered by Google App Engine
This is Rietveld 408576698