Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome_frame/test/net/fake_external_tab.h

Issue 9959106: Modify chrome_frame_net_tests to integrate the refactoring to ProcessSingleton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Convert some includes to forward declarations. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/net/fake_external_tab.h
diff --git a/chrome_frame/test/net/fake_external_tab.h b/chrome_frame/test/net/fake_external_tab.h
index cd92dc082e4604c7f04f3d8ef93d94b6029b257e..334b34edfb803fd212dd1695769a86fc57cac4cf 100644
--- a/chrome_frame/test/net/fake_external_tab.h
+++ b/chrome_frame/test/net/fake_external_tab.h
@@ -14,18 +14,17 @@
#include "base/process.h"
#include "base/win/scoped_handle.h"
#include "chrome/browser/browser_process_impl.h"
-#include "chrome_frame/test/ie_configurator.h"
-#include "chrome_frame/test/net/process_singleton_subclass.h"
#include "chrome_frame/test/net/test_automation_provider.h"
#include "chrome_frame/test/test_server.h"
#include "chrome_frame/test_utils.h"
#include "content/public/browser/browser_main_parts.h"
#include "content/public/browser/browser_thread.h"
#include "net/base/net_test_suite.h"
-#include "net/url_request/url_request_test_util.h"
+class CommandLine;
class FakeBrowserProcessImpl;
class ProcessSingleton;
+class ScopedCustomUrlRequestTestHttpHost;
namespace content {
class NotificationService;
@@ -35,6 +34,10 @@ namespace logging_win {
class FileLogger;
} // namespace logging_win
+namespace chrome_frame_test {
+class IEConfigurator;
+} // namespace chrome_frame_test
+
class FakeExternalTab {
public:
FakeExternalTab();
@@ -54,7 +57,6 @@ class FakeExternalTab {
scoped_ptr<FakeBrowserProcessImpl> browser_process_;
FilePath overridden_user_dir_;
FilePath user_data_dir_;
- scoped_ptr<ProcessSingleton> process_singleton_;
scoped_ptr<content::NotificationService> notificaton_service_;
DISALLOW_COPY_AND_ASSIGN(FakeExternalTab);
@@ -69,7 +71,6 @@ class FakeExternalTab {
// lifetime events.
class CFUrlRequestUnittestRunner
: public NetTestSuite,
- public ProcessSingletonSubclassDelegate,
public TestAutomationProviderDelegate,
public content::BrowserMainParts {
public:
@@ -84,10 +85,6 @@ class CFUrlRequestUnittestRunner
virtual void Initialize();
virtual void Shutdown();
- // ProcessSingletonSubclassDelegate.
- virtual void OnConnectAutomationProviderToChannel(
- const std::string& channel_id);
-
// TestAutomationProviderDelegate.
virtual void OnInitialTabLoaded();
virtual void OnProviderDestroyed();
@@ -138,7 +135,6 @@ class CFUrlRequestUnittestRunner
// The fake chrome instance.
scoped_ptr<FakeExternalTab> fake_chrome_;
- scoped_ptr<ProcessSingletonSubclass> pss_subclass_;
ScopedChromeFrameRegistrar registrar_;
int test_result_;
@@ -154,9 +150,13 @@ class CFUrlRequestUnittestRunner
void StartInitializationTimeout();
void OnInitializationTimeout();
+ bool ProcessSingletonNotificationCallback(const CommandLine& command_line,
+ const FilePath& current_directory);
+
bool launch_browser_;
bool prompt_after_setup_;
bool tests_ran_;
+ scoped_ptr<ProcessSingleton> process_singleton_;
base::CancelableClosure timeout_closure_;
scoped_ptr<logging_win::FileLogger> file_logger_;
FilePath log_file_;

Powered by Google App Engine
This is Rietveld 408576698