Issue 9959106: Modify chrome_frame_net_tests to integrate the refactoring to ProcessSingleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959106: Modify chrome_frame_net_tests to integrate the refactoring to ProcessSingleton. (Closed)

Created:
8 years, 8 months ago by erikwright (departed)

Modified:
8 years, 3 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modify chrome_frame_net_tests to integrate the refactoring to ProcessSingleton. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154628

Patch Set 3 : Convert some includes to forward declarations. #

Total comments: 1

Patch Set 5 : Sync. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -177 lines)			Patch
M	chrome_frame/chrome_frame.gyp	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.h	View	1 2 3	7 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.cc	View	1 2 3	8 chunks	+36 lines, -18 lines	0 comments	Download
D	chrome_frame/test/net/process_singleton_subclass.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome_frame/test/net/process_singleton_subclass.cc	View		1 chunk	+0 lines, -110 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM, looks awesome! http://codereview.chromium.org/9959106/diff/6001/chrome_frame/test/net/fake_external_tab.cc File chrome_frame/test/net/fake_external_tab.cc (right): http://codereview.chromium.org/9959106/diff/6001/chrome_frame/test/net/fake_external_tab.cc#newcode794 chrome_frame/test/net/fake_external_tab.cc:794: DCHECK(MessageLoop::current()->type() == MessageLoop::TYPE_UI); I suggest adding ...

8 years, 8 months ago (2012-04-05 17:24:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9959106/22002

8 years, 3 months ago (2012-09-01 20:24:39 UTC) #3

Change committed as 154628

Expand Messages | Collapse Messages

Issue 9959106: Modify chrome_frame_net_tests to integrate the refactoring to ProcessSingleton. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merge master. #

Patch Set 3 : Convert some includes to forward declarations. #

Patch Set 4 : Sync. #

Patch Set 5 : Sync. #

Messages