Exposing the child process unique ID through the task manager.

Exposing the child process unique ID through the task manager. This is an initial step required for implementing the processes extension API.

BUG=32302
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130952

[nasko, 2012-04-03 19:05:25]

Charlie, can you review the changes to expose the unique child process ID
through the task manager?

[Charlie Reis, 2012-04-04 17:53:40]

Yes, this seems useful.  Please add the bug number for the processes extension
API (since this contributes towards that) and mark it TEST=none.

Does the presubmit check say whether any owner reviews are required?

https://chromiumcodereview.appspot.com/9959101/diff/3011/chrome/browser/task_...
File chrome/browser/task_manager/task_manager.h (right):

https://chromiumcodereview.appspot.com/9959101/diff/3011/chrome/browser/task_...
chrome/browser/task_manager/task_manager.h:380: // Returns the unique child
process ID.
This needs more of a description to distinguish it from the operating system's
process ID.  We should also mention it's not displayed to the user in the Task
Manager, but is useful for internal tracking and for extension APIs.

[nasko, 2012-04-04 18:13:19]

Improved the comment.

Mark, can you review for cocoa owner approval?

Yoshiki, can you review for Task Manager owner approval?

Thanks!
Nasko

https://chromiumcodereview.appspot.com/9959101/diff/3011/chrome/browser/task_...
File chrome/browser/task_manager/task_manager.h (right):

https://chromiumcodereview.appspot.com/9959101/diff/3011/chrome/browser/task_...
chrome/browser/task_manager/task_manager.h:380: // Returns the unique child
process ID.
On 2012/04/04 17:53:40, creis wrote:
> This needs more of a description to distinguish it from the operating system's
> process ID.  We should also mention it's not displayed to the user in the Task
> Manager, but is useful for internal tracking and for extension APIs.

Done.

[Mark Mentovai, 2012-04-04 18:21:32]

I only reviewed chrome/browser/ui/cocoa/task_manager_mac_unittest.mm.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/ui/co...
File chrome/browser/ui/cocoa/task_manager_mac_unittest.mm (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/ui/co...
chrome/browser/ui/cocoa/task_manager_mac_unittest.mm:30: return (int)
base::GetCurrentProcId();
Don’t use (C-style)casts, ever, anywhere. Use C++<style>(casts). See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Castin...

[Charlie Reis, 2012-04-04 19:23:29]

LGTM with Mark's cast fix and the nits below.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
File chrome/browser/task_manager/task_manager.h (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
chrome/browser/task_manager/task_manager.h:381: // process id. This is used to
identifying processes internally and by
nit: identify
nit: for extensions

[yoshiki, 2012-04-04 19:29:09]

LGTM with the other cast fix.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
File chrome/browser/task_manager/task_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
chrome/browser/task_manager/task_manager_unittest.cc:46: return (int)
base::GetCurrentProcId();
You should use C++ style cast as same as in task_manager_mac_unittest.mm.

[nasko, 2012-04-04 19:31:24]

Fixed the casts and the comment.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
File chrome/browser/task_manager/task_manager.h (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
chrome/browser/task_manager/task_manager.h:381: // process id. This is used to
identifying processes internally and by
On 2012/04/04 19:23:29, creis wrote:
> nit: identify
> nit: for extensions

Done.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
File chrome/browser/task_manager/task_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/task_...
chrome/browser/task_manager/task_manager_unittest.cc:46: return (int)
base::GetCurrentProcId();
On 2012/04/04 19:29:09, yoshiki wrote:
> You should use C++ style cast as same as in task_manager_mac_unittest.mm.

Done.

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/ui/co...
File chrome/browser/ui/cocoa/task_manager_mac_unittest.mm (right):

https://chromiumcodereview.appspot.com/9959101/diff/8002/chrome/browser/ui/co...
chrome/browser/ui/cocoa/task_manager_mac_unittest.mm:30: return (int)
base::GetCurrentProcId();
On 2012/04/04 18:21:32, Mark Mentovai wrote:
> Don’t use (C-style)casts, ever, anywhere. Use C++<style>(casts). See
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Castin...

Done.

[Mark Mentovai, 2012-04-04 19:59:01]

LGTM

I only reviewed chrome/browser/ui/cocoa/task_manager_mac_unittest.mm and
chrome/browser/task_manager/task_manager.h.

[commit-bot: I haz the power, 2012-04-05 15:25:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nasko@chromium.org/9959101/13003

[commit-bot: I haz the power, 2012-04-05 17:18:25]

Change committed as 130952