Add probability of culling if sync is enabled to https://chromiumcodereview.appspot.com/9585020/ In…

Add probability of culling if sync is enabled to https://chromiumcodereview.appspot.com/9585020/ Initially set it to 0%.
Original cl:
Cull autofill entries older than 60 days.
Tested with 20K Autocomplete entries selected 100000 times. 500 of them are in range.
---Start MergeDataAndStartSyncing for autofill
Read from db - 7s
Sift through them selecting only those needed for update - ~0.5s
Process 476 changes - <1s
---End MergeDataAndStartSyncing for autofill - total ~8.5 s
Callback back after deleting extra entries - 17s


BUG=28990
TEST=unit-test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130852

[GeorgeY, 2012-04-03 00:07:01]

new changes are in src/chrome/browser/webdata/autocomplete_syncable_service.cc
only - see CullSyncedData()

[Ilya Sherman, 2012-04-03 00:09:25]

LGTM, thanks

[Ilya Sherman, 2012-04-03 00:13:36]

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
chrome/browser/webdata/autocomplete_syncable_service.cc:83: bool
CullSyncedData() {
nit: Actually, perhaps "ShouldCullSyncedData()"?

[GeorgeY, 2012-04-03 00:28:44]

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
chrome/browser/webdata/autocomplete_syncable_service.cc:83: bool
CullSyncedData() {
On 2012/04/03 00:13:36, Ilya Sherman wrote:
> nit: Actually, perhaps "ShouldCullSyncedData()"?

sure

[Ilya Sherman, 2012-04-03 00:31:05]

LGTM

[Nicolas Zea, 2012-04-03 00:39:09]

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
chrome/browser/webdata/autocomplete_syncable_service.cc:177:
new_changes.push_back(SyncChange(SyncChange::ACTION_DELETE,
This logic should also be protected by CullSyncedData(), else a new client that
attempts to sync will start deleting all the old data.

[GeorgeY, 2012-04-03 16:55:01]

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/9959086/diff/1/chrome/browser/webdata/...
chrome/browser/webdata/autocomplete_syncable_service.cc:177:
new_changes.push_back(SyncChange(SyncChange::ACTION_DELETE,
On 2012/04/03 00:39:09, nzea wrote:
> This logic should also be protected by CullSyncedData(), else a new client
that
> attempts to sync will start deleting all the old data.

Done.

[Nicolas Zea, 2012-04-03 16:55:44]

lgtm

[commit-bot: I haz the power, 2012-04-03 16:56:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-03 17:45:13]

Try job failure for 9959086-5003 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-03 18:04:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-03 18:45:57]

Try job failure for 9959086-5003 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-03 18:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-03 22:42:53]

Try job failure for 9959086-5003 (retry) on win_rel for steps "browser_tests,
unit_tests".
It's a second try, previously, steps "browser_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-03 22:46:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-03 23:34:35]

Try job failure for 9959086-5003 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-04 01:10:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-04 05:08:30]

Try job failure for 9959086-5003 (retry) on win_rel for steps "browser_tests,
unit_tests".
It's a second try, previously, steps "browser_tests, net_unittests, unit_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-04 16:49:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-04 17:54:14]

Try job failure for 9959086-5003 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-04-04 19:11:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-05 00:41:26]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 130786, job name
was 9959086-5003 (retry) (retry) (previous was lost) (retry).

[commit-bot: I haz the power, 2012-04-05 00:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/georgey@chromium.org/9959086/5003

[commit-bot: I haz the power, 2012-04-05 07:15:20]

Change committed as 130852