Allow longer branch names to be center justified with git cl status.

Allow longer branch names to be center justified with git cl status.

(Using "." instead of " " so that codereview shows the alignment)

Before:

% git cl status  
Branches associated with reviews:
..CloseIdleSpdySessions:.None
..CloseSockets:.9755011
..GetNegotiatedProtocol:.9958028
..LayeredSocketPool:.9861032
..ReleaseIdleSpdySessions:.9733017
..SSLClientSocket:.9616019
.......Spdy3:.9958023
...SpdyProxy:.None
...SpdyTests:.None
.......crash:.9809033
........leak:.None
......master:.None
.......spdy3:.9958023

After

% git cl status
Branches associated with reviews:
......CloseIdleSpdySessions:.None
...............CloseSockets:.9755011
......GetNegotiatedProtocol:.9958028
..........LayeredSocketPool:.9861032
....ReleaseIdleSpdySessions:.9733017
............SSLClientSocket:.9616019
......................Spdy3:.9958023
..................SpdyProxy:.None
..................SpdyTests:.None
......................crash:.9809033
.......................leak:.None
.....................master:.None
......................spdy3:.9958023

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130189

[Ryan Hamilton, 2012-04-02 19:28:54]

Here's a small change to git_cl.py which improves alignment of long branch names
(which I use :>)

[M-A Ruel, 2012-04-02 19:33:41]

On 2012/04/02 19:28:54, Ryan Hamilton wrote:
> Here's a small change to git_cl.py which improves alignment of long branch
names
> (which I use :>)

Then I'd prefer the value to be calculated.

alignment = max(len(b) for b in sorted(branches.splitlines()))

[M-A Ruel, 2012-04-02 19:33:56]

On 2012/04/02 19:33:41, Marc-Antoine Ruel wrote:
> On 2012/04/02 19:28:54, Ryan Hamilton wrote:
> > Here's a small change to git_cl.py which improves alignment of long branch
> names
> > (which I use :>)
> 
> Then I'd prefer the value to be calculated.
> 
> alignment = max(len(b) for b in sorted(branches.splitlines()))

with min(5, ...)

[M-A Ruel, 2012-04-02 19:34:06]

On 2012/04/02 19:33:56, Marc-Antoine Ruel wrote:
> On 2012/04/02 19:33:41, Marc-Antoine Ruel wrote:
> > On 2012/04/02 19:28:54, Ryan Hamilton wrote:
> > > Here's a small change to git_cl.py which improves alignment of long branch
> > names
> > > (which I use :>)
> > 
> > Then I'd prefer the value to be calculated.
> > 
> > alignment = max(len(b) for b in sorted(branches.splitlines()))
> 
> with min(5, ...)

Err, max(5, ...)

[Ryan Hamilton, 2012-04-02 19:49:47]

On 2012/04/02 19:33:41, Marc-Antoine Ruel wrote:
> On 2012/04/02 19:28:54, Ryan Hamilton wrote:
> > Here's a small change to git_cl.py which improves alignment of long branch
> names
> > (which I use :>)

Thanks for the quick review!

> Then I'd prefer the value to be calculated.
> 
> alignment = max(len(b) for b in sorted(branches.splitlines()))

That doesn't quite work because "b" in that code is a string like:

  refs/heads/CloseIdleSpdySessions

So we need to first extract out the branch name, then compute the length off of
that.  I believe I've done that in Patch Set 2.  PTAL?

[M-A Ruel, 2012-04-02 19:56:25]

https://chromiumcodereview.appspot.com/9959073/diff/4002/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/9959073/diff/4002/git_cl.py#newcode802
git_cl.py:802: alignment = 5
You can code it even shorter with:

print 'Branches associated with reviews:'
changes = (Changelist(branchref=b) for b in branches.splitlines())
branches = dict((cl.GetBranch(), cl.GetIssue()) for cl in changes)
alignment = max(5, max(len(b) for b in branches))
for branch in sorted(branches):
  print "  %*s: %s" % (alignment, branch, branches[branch])

[Ryan Hamilton, 2012-04-02 20:00:04]

On 2012/04/02 19:56:25, Marc-Antoine Ruel wrote:
> https://chromiumcodereview.appspot.com/9959073/diff/4002/git_cl.py
> File git_cl.py (right):
> 
> https://chromiumcodereview.appspot.com/9959073/diff/4002/git_cl.py#newcode802
> git_cl.py:802: alignment = 5
> You can code it even shorter with:
> 
> print 'Branches associated with reviews:'
> changes = (Changelist(branchref=b) for b in branches.splitlines())
> branches = dict((cl.GetBranch(), cl.GetIssue()) for cl in changes)
> alignment = max(5, max(len(b) for b in branches))
> for branch in sorted(branches):
>   print "  %*s: %s" % (alignment, branch, branches[branch])

Even better!  Done.

[M-A Ruel, 2012-04-02 20:00:32]

lgtm

[commit-bot: I haz the power, 2012-04-02 20:03:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9959073/3002

[commit-bot: I haz the power, 2012-04-02 20:10:36]

Change committed as 130189