Issue 9959038: Removed ProfileSyncService::UIShouldDepictAuthInProgress

Issue 9959038: Removed ProfileSyncService::UIShouldDepictAuthInProgress (Closed)

Created:
8 years, 8 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 8 months ago

Reviewers:
rlarocque, sky

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, ncarter (slow), akalin, Raghu Simha, estade+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Removed ProfileSyncService::UIShouldDepictAuthInProgress Changed so all code queries the auth-in-progress status directly from SigninManager. BUG=95269 TEST=existing unit tests suffice Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131709

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -56 lines)			Patch
M	chrome/browser/signin/signin_manager.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 2 3	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2 3	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_global_error.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_global_error.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/sync_global_error_unittest.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 2	3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	1 2	8 chunks	+19 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util_mac.mm	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util_unittest.cc	View	1 2	14 chunks	+29 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/browser_options_handler2.cc	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Andrew T Wilson (Slow)

This is just a refactoring to have callers invoke SigninManager::AuthInProgress() directly rather than calling through ...

8 years, 8 months ago (2012-03-31 16:26:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/9959038/7001

8 years, 8 months ago (2012-04-11 00:19:49 UTC) #4

Change committed as 131709