Move NextProto enum to a new file net/socket/next_proto.h

Move NextProto enum to a new file net/socket/next_proto.h

BUG=120890
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130038

[Ryan Hamilton, 2012-03-30 19:04:02]

Hi Wan-Teh, as we discussed, this CL move the NextProto into a new header file
in preparation for adding a GetNegotiatedProtocol method to StreamSocket.

[wtc, 2012-03-30 20:53:51]

Patch set 2 LGTM.  I suggest some changes.

http://codereview.chromium.org/9959033/diff/1074/net/base/next_proto.h
File net/base/next_proto.h (right):

http://codereview.chromium.org/9959033/diff/1074/net/base/next_proto.h#newcode5
net/base/next_proto.h:5: #ifndef NET_BASE_NEXT_PROTO_H_

Please move this header to the net/socket directory.

You'll need to update the pathname of this header in
net/socket/stream_socket.h and in the CL's description.

http://codereview.chromium.org/9959033/diff/1074/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/9959033/diff/1074/net/socket/socket_test_util....
net/socket/socket_test_util.h:603: virtual SSLClientSocket::NextProtoStatus
GetNextProto(std::string* proto,

Why is it necessary to add SSLClientSocket:: to the
NextProtoStatus type here?

If this change is not necessary, I'd prefer that we omit
SSLClientSocket:: for brevity.

Note that you made this change to several other files, too.

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_proxy_client_s...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_proxy_client_s...
net/spdy/spdy_proxy_client_socket.cc:80: NextProto

Nit: move this to the next line.

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:469: kProtoUnknown;

Nit: move this to the previous line.

[commit-bot: I haz the power, 2012-03-30 21:08:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9959033/6001

[Ryan Hamilton, 2012-03-30 21:12:13]

Thanks for the lgtm!

http://codereview.chromium.org/9959033/diff/1074/net/base/next_proto.h
File net/base/next_proto.h (right):

http://codereview.chromium.org/9959033/diff/1074/net/base/next_proto.h#newcode5
net/base/next_proto.h:5: #ifndef NET_BASE_NEXT_PROTO_H_
On 2012/03/30 20:53:51, wtc wrote:
> 
> Please move this header to the net/socket directory.
> 
> You'll need to update the pathname of this header in
> net/socket/stream_socket.h and in the CL's description.

Done.

http://codereview.chromium.org/9959033/diff/1074/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/9959033/diff/1074/net/socket/socket_test_util....
net/socket/socket_test_util.h:603: virtual SSLClientSocket::NextProtoStatus
GetNextProto(std::string* proto,
On 2012/03/30 20:53:51, wtc wrote:
> 
> Why is it necessary to add SSLClientSocket:: to the
> NextProtoStatus type here?
> 
> If this change is not necessary, I'd prefer that we omit
> SSLClientSocket:: for brevity.
> 
> Note that you made this change to several other files, too.

Whoops, I cooked up a script to help me with this change, and it looks like it
was overly aggressive.  I'll fix this.

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_proxy_client_s...
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_proxy_client_s...
net/spdy/spdy_proxy_client_socket.cc:80: NextProto
On 2012/03/30 20:53:51, wtc wrote:
> 
> Nit: move this to the next line.

Done.

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/9959033/diff/1074/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:469: kProtoUnknown;
On 2012/03/30 20:53:51, wtc wrote:
> 
> Nit: move this to the previous line.

Done.

[commit-bot: I haz the power, 2012-03-31 00:15:20]

Try job failure for 9959033-6001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-31 00:19:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9959033/6001

[commit-bot: I haz the power, 2012-03-31 03:58:49]

Change committed as 130038