Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: content/test/layout_browsertest.cc

Issue 9959028: Convert the media and audio UI test to a browser_test. browser_tests are sharded and run quicker, a… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync before bad v8 roll and fix failing test Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/audio_browsertest.cc ('K') | « content/test/layout_browsertest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/layout_browsertest.cc
===================================================================
--- content/test/layout_browsertest.cc (revision 129871)
+++ content/test/layout_browsertest.cc (working copy)
@@ -84,14 +84,14 @@
InProcessBrowserLayoutTest::InProcessBrowserLayoutTest(
const FilePath& test_parent_dir, const FilePath& test_case_dir)
: test_parent_dir_(test_parent_dir), test_case_dir_(test_case_dir),
- port_(-2) {
+ port_(-2), wait_until_done_(true) {
EnableDOMAutomation();
}
InProcessBrowserLayoutTest::InProcessBrowserLayoutTest(
const FilePath& test_parent_dir, const FilePath& test_case_dir, int port)
: test_parent_dir_(test_parent_dir), test_case_dir_(test_case_dir),
- port_(port) {
+ port_(port), wait_until_done_(true) {
EnableDOMAutomation();
}
@@ -180,10 +180,13 @@
ui_test_utils::TitleWatcher title_watcher(
browser()->GetSelectedWebContents(), expected_title);
ui_test_utils::NavigateToURL(browser(), url);
- LOG(INFO) << "Navigation completed, now waiting for title.";
- string16 final_title = title_watcher.WaitAndGetTitle();
- EXPECT_EQ(expected_title, final_title);
+ if (wait_until_done_) {
+ LOG(INFO) << "Navigation completed, now waiting for notifyDone.";
+ string16 final_title = title_watcher.WaitAndGetTitle();
+ EXPECT_EQ(expected_title, final_title);
+ }
+
std::string actual_text;
ScrapeResultFromBrowser(browser(), &actual_text);
ReplaceSubstringsAfterOffset(&actual_text, 0, "\r", "");
« content/browser/audio_browsertest.cc ('K') | « content/test/layout_browsertest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698