Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/media/player.html

Issue 9959028: Convert the media and audio UI test to a browser_test. browser_tests are sharded and run quicker, a… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync before bad v8 roll and fix failing test Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/audio_browsertest.cc » ('j') | content/browser/audio_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/media/player.html
===================================================================
--- chrome/test/data/media/player.html (revision 129871)
+++ chrome/test/data/media/player.html (working copy)
@@ -29,7 +29,7 @@
// Install event handlers.
InstallEventHandler('error',
scherkus (not reviewing) 2012/03/30 19:53:08 nit: fit on one line?
jam 2012/03/30 20:19:06 Done.
- 'document.title = "ERROR = " + player.error.code');
+ 'document.title = "ERROR"');
InstallEventHandler('playing', 'document.title = "PLAYING"');
// Starts the player.
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/audio_browsertest.cc » ('j') | content/browser/audio_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698