Use ScopedProcessInformation and other RAII types in sandbox.

sandbox/src/sandbox.h

Index: sandbox/src/sandbox.h
diff --git a/sandbox/src/sandbox.h b/sandbox/src/sandbox.h
index bbc4f77f6d9297211a70bfd5c3d0c2f673683903..3b5d451213f14d05844d3642572e491e3a62c418 100644
--- a/sandbox/src/sandbox.h
+++ b/sandbox/src/sandbox.h
@@ -25,6 +25,14 @@
 #include "sandbox/src/sandbox_policy.h"
 #include "sandbox/src/sandbox_types.h"
 
+namespace base {
+namespace win {
+
+class ScopedProcessInformation;
+
+}  // namespace win
+}  // namespace namespace
+
 // sandbox: Google User-Land Application Sandbox
 namespace sandbox {
 
@@ -69,14 +77,14 @@ class BrokerServices {
   //   policy: This is the pointer to the policy object for the sandbox to
   //   be created.
   //   target: returns the resulting target process information such as process
-  //   handle and PID just as if CreateProcess() had been called. The caller is
-  //   responsible for closing the handles returned in this structure.
+  //   handle and PID just as if CreateProcess() had been called.
   // Returns:
   //   ALL_OK if successful. All other return values imply failure.
-  virtual ResultCode SpawnTarget(const wchar_t* exe_path,
-                                 const wchar_t* command_line,
-                                 TargetPolicy* policy,
-                                 PROCESS_INFORMATION* target) = 0;
+  virtual ResultCode SpawnTarget(
+      const wchar_t* exe_path,
+      const wchar_t* command_line,
+      TargetPolicy* policy,
+      base::win::ScopedProcessInformation* target) = 0;

[cpu_(ooo_6.6-7.5), 2012/04/02 21:11:50]

I rather keep this interface, in fact this whole file free of base:: objects.
There are several reasons, including 3rd party users of this code.

But it is fine in other headers, I mean in inner classes. The classes here (plus
TargetPolicy) are the only external surface.

 
   // This call blocks (waits) for all the targets to terminate.
   // Returns: