Use ScopedProcessInformation and other RAII types in sandbox.

sandbox/src/interception_unittest.cc

Index: sandbox/src/interception_unittest.cc
diff --git a/sandbox/src/interception_unittest.cc b/sandbox/src/interception_unittest.cc
index a0dd98d23cc9d7d255da229a976f14d025d2ee63..bcb576f7ed6682cc1f018f6cf67ccd93726a47e6 100644
--- a/sandbox/src/interception_unittest.cc
+++ b/sandbox/src/interception_unittest.cc
@@ -79,7 +79,13 @@ TEST(InterceptionManagerTest, BufferLayout1) {
   wchar_t exe_name[MAX_PATH];
   ASSERT_NE(0u, GetModuleFileName(NULL, exe_name, MAX_PATH - 1));
 
-  TargetProcess *target = MakeTestTargetProcess(::GetCurrentProcess(),
+  base::win::ScopedHandle current_process;
+  ASSERT_TRUE(
+      ::DuplicateHandle(::GetCurrentProcess(), ::GetCurrentProcess(),
+                        ::GetCurrentProcess(), current_process.Receive(),
+                        0, FALSE, DUPLICATE_SAME_ACCESS));
+
+  TargetProcess *target = MakeTestTargetProcess(current_process.Take(),

[erikwright (departed), 2012/03/30 16:29:31]

Previously this would have resulted in a call to CloseHandle() with the special
GetCurrentProcess  handle

                                                 ::GetModuleHandle(exe_name));
 
   InterceptionManager interceptions(target, true);
@@ -166,7 +172,13 @@ TEST(InterceptionManagerTest, BufferLayout2) {
   wchar_t exe_name[MAX_PATH];
   ASSERT_NE(0u, GetModuleFileName(NULL, exe_name, MAX_PATH - 1));
 
-  TargetProcess *target = MakeTestTargetProcess(::GetCurrentProcess(),
+  base::win::ScopedHandle current_process;

[erikwright (departed), 2012/03/30 16:29:31]

ditto

+  ASSERT_TRUE(
+      ::DuplicateHandle(::GetCurrentProcess(), ::GetCurrentProcess(),
+                        ::GetCurrentProcess(), current_process.Receive(),
+                        0, FALSE, DUPLICATE_SAME_ACCESS));
+
+  TargetProcess *target = MakeTestTargetProcess(current_process.Take(),
                                                 ::GetModuleHandle(exe_name));
 
   InterceptionManager interceptions(target, true);