Use ScopedProcessInformation and other RAII types in sandbox.

sandbox/src/process_policy_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "base/sys_string_conversions.h"
 #include "base/win/scoped_handle.h"
+#include "base/win/scoped_process_information.h"
 #include "sandbox/src/sandbox.h"
 #include "sandbox/src/sandbox_policy.h"
 #include "sandbox/src/sandbox_factory.h"
 #include "sandbox/tests/common/controller.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // While the shell API provides better calls than this home brew function
 // we use GetSystemWindowsDirectoryW which does not query the registry so
 // it is safe to use after revert.
 std::wstring MakeFullPathToSystem32(const wchar_t* name) {
   wchar_t windows_path[MAX_PATH] = {0};
   ::GetSystemWindowsDirectoryW(windows_path, MAX_PATH);
   std::wstring full_path(windows_path);
   if (full_path.empty()) {
     return full_path;
   }
   full_path += L"\\system32\\";
   full_path += name;
   return full_path;
 }
 
 // Creates a process with the |exe| and |command| parameter using the
 // unicode and ascii version of the api.
 sandbox::SboxTestResult CreateProcessHelper(const std::wstring &exe,
                                             const std::wstring &command) {
-  PROCESS_INFORMATION pi;
+  base::win::ScopedProcessInformation pi;
   STARTUPINFOW si = {sizeof(si)};
 
   const wchar_t *exe_name = NULL;
   if (!exe.empty())
     exe_name = exe.c_str();
 
   const wchar_t *cmd_line = NULL;
   if (!command.empty())
     cmd_line = command.c_str();
 
   // Create the process with the unicode version of the API.
   sandbox::SboxTestResult ret1 = sandbox::SBOX_TEST_FAILED;
   if (!::CreateProcessW(exe_name, const_cast<wchar_t*>(cmd_line), NULL, NULL,
-                        FALSE, 0, NULL, NULL, &si, &pi)) {
+                        FALSE, 0, NULL, NULL, &si, pi.Receive())) {
     DWORD last_error = GetLastError();
     if ((ERROR_NOT_ENOUGH_QUOTA == last_error) ||
         (ERROR_ACCESS_DENIED == last_error) ||
         (ERROR_FILE_NOT_FOUND == last_error)) {
       ret1 = sandbox::SBOX_TEST_DENIED;
     } else {
       ret1 = sandbox::SBOX_TEST_FAILED;
     }
   } else {
     ret1 = sandbox::SBOX_TEST_SUCCEEDED;
   }
 
+  pi.Close();
+
   // Do the same with the ansi version of the api
   STARTUPINFOA sia = {sizeof(sia)};
   sandbox::SboxTestResult ret2 = sandbox::SBOX_TEST_FAILED;
 
   std::string narrow_cmd_line;
   if (cmd_line)
     narrow_cmd_line = base::SysWideToMultiByte(cmd_line, CP_UTF8);
   if (!::CreateProcessA(
         exe_name ? base::SysWideToMultiByte(exe_name, CP_UTF8).c_str() : NULL,
         cmd_line ? const_cast<char*>(narrow_cmd_line.c_str()) : NULL,
-        NULL, NULL, FALSE, 0, NULL, NULL, &sia, &pi)) {
+        NULL, NULL, FALSE, 0, NULL, NULL, &sia, pi.Receive())) {
     DWORD last_error = GetLastError();
     if ((ERROR_NOT_ENOUGH_QUOTA == last_error) ||
         (ERROR_ACCESS_DENIED == last_error) ||
         (ERROR_FILE_NOT_FOUND == last_error)) {
       ret2 = sandbox::SBOX_TEST_DENIED;
     } else {
       ret2 = sandbox::SBOX_TEST_FAILED;
     }
   } else {
     ret2 = sandbox::SBOX_TEST_SUCCEEDED;
@@ skipping 78 matching lines @@
 // Creates a process and checks if it's possible to get a handle to it's token.
 SBOX_TESTS_COMMAND int Process_GetChildProcessToken(int argc, wchar_t **argv) {
   if (argc != 1)
     return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
 
   if ((NULL == argv) || (NULL == argv[0]))
     return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
 
   std::wstring path = MakeFullPathToSystem32(argv[0]);
 
-  PROCESS_INFORMATION pi = {0};
+  base::win::ScopedProcessInformation pi;
   STARTUPINFOW si = {sizeof(si)};
 
   if (!::CreateProcessW(path.c_str(), NULL, NULL, NULL, FALSE, CREATE_SUSPENDED,
-                        NULL, NULL, &si, &pi)) {
+                        NULL, NULL, &si, pi.Receive())) {
       return SBOX_TEST_FAILED;
   }
 
-  base::win::ScopedHandle process(pi.hProcess);
-  base::win::ScopedHandle thread(pi.hThread);
-
   HANDLE token = NULL;
-  BOOL result = ::OpenProcessToken(process.Get(), TOKEN_IMPERSONATE, &token);
+  BOOL result =
+      ::OpenProcessToken(pi.process_handle(), TOKEN_IMPERSONATE, &token);
   DWORD error = ::GetLastError();
 
   base::win::ScopedHandle token_handle(token);
 
-  if (!::TerminateProcess(process.Get(), 0))
+  if (!::TerminateProcess(pi.process_handle(), 0))
     return SBOX_TEST_FAILED;
 
   if (result && token)
     return SBOX_TEST_SUCCEEDED;
 
   if (ERROR_ACCESS_DENIED == error)
     return SBOX_TEST_DENIED;
 
   return SBOX_TEST_FAILED;
 }
@@ skipping 84 matching lines @@
   ASSERT_TRUE(!exe_path.empty());
   EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_PROCESS,
                              TargetPolicy::PROCESS_ALL_EXEC,
                              exe_path.c_str()));
 
   EXPECT_EQ(SBOX_TEST_SUCCEEDED,
             runner.RunTest(L"Process_GetChildProcessToken findstr.exe"));
 }
 
 }  // namespace sandbox