Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 9958156: Add #include <iterator> to files that use std::back_inserter. (Closed)

Created:
8 years, 8 months ago by halyavin
Modified:
8 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright (departed), James Su, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/process_util_posix.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/prefix_set_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/win/supalink/supalink.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
halyavin
8 years, 8 months ago (2012-04-04 10:36:42 UTC) #1
brettw
https://chromiumcodereview.appspot.com/9958156/diff/1/base/process_util_posix.cc File base/process_util_posix.cc (right): https://chromiumcodereview.appspot.com/9958156/diff/1/base/process_util_posix.cc#newcode8 base/process_util_posix.cc:8: #include <iterator> C++ includes go in a group after ...
8 years, 8 months ago (2012-04-04 15:39:14 UTC) #2
halyavin
https://chromiumcodereview.appspot.com/9958156/diff/1/base/process_util_posix.cc File base/process_util_posix.cc (right): https://chromiumcodereview.appspot.com/9958156/diff/1/base/process_util_posix.cc#newcode8 base/process_util_posix.cc:8: #include <iterator> On 2012/04/04 15:39:14, brettw wrote: > C++ ...
8 years, 8 months ago (2012-04-04 16:12:01 UTC) #3
brettw
lgtm
8 years, 8 months ago (2012-04-04 17:09:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/9958156/8001
8 years, 8 months ago (2012-04-04 19:06:00 UTC) #5
commit-bot: I haz the power
Try job failure for 9958156-8001 (previous was lost) (retry) on win_rel for step "browser_tests". It's ...
8 years, 8 months ago (2012-04-04 23:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/9958156/8001
8 years, 8 months ago (2012-04-05 06:29:43 UTC) #7
commit-bot: I haz the power
Try job failure for 9958156-8001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-05 09:54:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/9958156/8001
8 years, 8 months ago (2012-04-05 09:55:34 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-05 11:38:40 UTC) #10
Change committed as 130893

Powered by Google App Engine
This is Rietveld 408576698