Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/io_thread.cc

Issue 9958145: Audit the destructors of classes derived from net::URLRequestContextGetter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ToT Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/policy/device_management_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/io_thread.h" 5 #include "chrome/browser/io_thread.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 context->set_server_bound_cert_service( 241 context->set_server_bound_cert_service(
242 globals->system_server_bound_cert_service.get()); 242 globals->system_server_bound_cert_service.get());
243 return context; 243 return context;
244 } 244 }
245 245
246 } // namespace 246 } // namespace
247 247
248 class SystemURLRequestContextGetter : public net::URLRequestContextGetter { 248 class SystemURLRequestContextGetter : public net::URLRequestContextGetter {
249 public: 249 public:
250 explicit SystemURLRequestContextGetter(IOThread* io_thread); 250 explicit SystemURLRequestContextGetter(IOThread* io_thread);
251 virtual ~SystemURLRequestContextGetter();
252 251
253 // Implementation for net::UrlRequestContextGetter. 252 // Implementation for net::UrlRequestContextGetter.
254 virtual net::URLRequestContext* GetURLRequestContext(); 253 virtual net::URLRequestContext* GetURLRequestContext();
255 virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const; 254 virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const;
256 255
256 protected:
257 virtual ~SystemURLRequestContextGetter();
258
257 private: 259 private:
258 IOThread* const io_thread_; // Weak pointer, owned by BrowserProcess. 260 IOThread* const io_thread_; // Weak pointer, owned by BrowserProcess.
259 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_; 261 scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
260 262
261 base::debug::LeakTracker<SystemURLRequestContextGetter> leak_tracker_; 263 base::debug::LeakTracker<SystemURLRequestContextGetter> leak_tracker_;
262 }; 264 };
263 265
264 SystemURLRequestContextGetter::SystemURLRequestContextGetter( 266 SystemURLRequestContextGetter::SystemURLRequestContextGetter(
265 IOThread* io_thread) 267 IOThread* io_thread)
266 : io_thread_(io_thread), 268 : io_thread_(io_thread),
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 new net::HttpNetworkLayer( 597 new net::HttpNetworkLayer(
596 new net::HttpNetworkSession(system_params))); 598 new net::HttpNetworkSession(system_params)));
597 globals_->system_ftp_transaction_factory.reset( 599 globals_->system_ftp_transaction_factory.reset(
598 new net::FtpNetworkLayer(globals_->host_resolver.get())); 600 new net::FtpNetworkLayer(globals_->host_resolver.get()));
599 globals_->system_request_context = 601 globals_->system_request_context =
600 ConstructSystemRequestContext(globals_, net_log_); 602 ConstructSystemRequestContext(globals_, net_log_);
601 603
602 sdch_manager_->set_sdch_fetcher( 604 sdch_manager_->set_sdch_fetcher(
603 new SdchDictionaryFetcher(system_url_request_context_getter_.get())); 605 new SdchDictionaryFetcher(system_url_request_context_getter_.get()));
604 } 606 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/policy/device_management_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698