remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh - Issue 9958083: Initial version of the Chromoting installer for Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh

Issue 9958083: Initial version of the Chromoting installer for Mac. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« remoting/host/installer/mac/Chromoting.packproj ('K') | « remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.json ('k') | remoting/host/installer/mac/Scripts/keystone_install.sh » ('j') | remoting/host/installer/mac/Scripts/remoting_postflight.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:executable
## -0,0 +1 ##
+*
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+LF
\ No newline at end of property

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 CONFIG_DIR=/Library/PrivilegedHelperTools

	4 HOST_EXE=$CONFIG_DIR/org.chromium.chromoting.me2me_host
	Lambros 2012/04/03 00:49:17 Maybe add NAME=org.chromium.chromoting and use it Maybe add NAME=org.chromium.chromoting and use it instead of writing out the name in full? garykac 2012/04/09 19:04:16 Done. Show quoted text On 2012/04/03 00:49:17, Lambros wrote: > Maybe add NAME=org.chromium.chromoting and use it instead of writing out the > name in full? Done.
	5 ENABLED_FILE=$CONFIG_DIR/org.chromium.chromoting.me2me_enabled

	6

	7 if [ "$1" = "--disable" ]; then

	8 echo $$
	Lambros 2012/04/03 00:49:17 Please could you add a comment before the first "e Please could you add a comment before the first "echo $$"? Something along these lines: This script is executed from base::mac::ExecuteWithPrivilegesAndWait(), which requires the child process to write its PID to stdout before anything else - see authorization_util.h. garykac 2012/04/09 19:04:16 Done. Show quoted text On 2012/04/03 00:49:17, Lambros wrote: > Please could you add a comment before the first "echo $$"? Something along > these lines: > This script is executed from base::mac::ExecuteWithPrivilegesAndWait(), which > requires the child process to write its PID to stdout before anything else - see > authorization_util.h. Done.
	9 rm -f "$ENABLED_FILE"

	10 elif [ "$1" = "--enable" ]; then

	11 echo $$

	12 touch "$ENABLED_FILE"

	13 else

	14 exec "$HOST_EXE" \

	15 --auth-config="$CONFIG_DIR/org.chromium.chromoting.json" \

	16 --host-config="$CONFIG_DIR/org.chromium.chromoting.json"

	17 fi

OLD	NEW