Reimplement Libcros fucntions using FlimflamProfileClient

chrome/browser/chromeos/cros/network_library_impl_cros.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/network_library_impl_cros.h"
 
 #include <dbus/dbus-glib.h>
+#include "base/command_line.h"
 #include "base/json/json_writer.h"  // for debug output only.
 #include "base/metrics/histogram.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/gvalue_util.h"
 #include "chrome/browser/chromeos/cros/native_network_constants.h"
 #include "chrome/browser/chromeos/cros/native_network_parser.h"
 #include "chrome/browser/chromeos/cros_settings.h"
 #include "content/public/browser/browser_thread.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
@@ skipping 19 matching lines @@
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////
 
 NetworkLibraryImplCros::NetworkLibraryImplCros()
     : NetworkLibraryImplBase(),
       network_manager_monitor_(NULL),
       data_plan_monitor_(NULL) {
+  const char kEnableNonLibcrosNetworkFunctions[] =
+      "enable-non-libcros-network-functions";

[stevenjb, 2012/04/12 17:34:36]

This should be defined in chrome_switches.h, and should be
"enable-dbus-network-fucntions" or "disable-libcros-network-fucntions" (or just
"disable-libcros").

[hashimoto, 2012/04/13 05:27:22]

I thought we should be as accurate as possible, but "disable-libcros" looks much
simpler.

+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          kEnableNonLibcrosNetworkFunctions)) {
+    LOG(INFO) << "Using non Libcros network fucntions.";
+    EnableNonLibcrosNetworkFunctions(true);
+  }
 }
 
 NetworkLibraryImplCros::~NetworkLibraryImplCros() {
   if (network_manager_monitor_)
     CrosDisconnectNetworkPropertiesMonitor(network_manager_monitor_);
   if (data_plan_monitor_)
     CrosDisconnectDataPlanUpdateMonitor(data_plan_monitor_);
   for (NetworkPropertiesMonitorMap::iterator iter =
            montitored_networks_.begin();
        iter != montitored_networks_.end(); ++iter) {
@@ skipping 1274 matching lines @@
         // Switch back to signed settings value.
         SetCellularDataRoamingAllowed(settings_value);
       }
     }
   }
   NotifyNetworkManagerChanged(false);  // Not forced.
   AddNetworkDeviceObserver(device_path, network_device_observer_.get());
 }
 
 }  // namespace chromeos