Convert plugin and GPU process to brokered handle duplication.

content/common/gpu/client/gpu_channel_host.h

Index: content/common/gpu/client/gpu_channel_host.h
===================================================================
--- content/common/gpu/client/gpu_channel_host.h	(revision 131361)
+++ content/common/gpu/client/gpu_channel_host.h	(working copy)
@@ -13,6 +13,7 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
+#include "base/process.h"
 #include "base/process_util.h"
 #include "base/synchronization/lock.h"
 #include "content/common/content_export.h"
@@ -83,13 +84,12 @@
 
   // Called on the render thread
   GpuChannelHost(GpuChannelHostFactory* factory,
-                 int gpu_process_id,
+                 int gpu_host_id,
                  int client_id);
   virtual ~GpuChannelHost();
 
   // Connect to GPU process channel.
-  void Connect(const IPC::ChannelHandle& channel_handle,
-               base::ProcessHandle client_process_for_gpu);
+  void Connect(const IPC::ChannelHandle& channel_handle);
 
   State state() const { return state_; }
 
@@ -152,7 +152,7 @@
   void ForciblyCloseChannel();
 
   GpuChannelHostFactory* factory() const { return factory_; }
-  int gpu_process_id() const { return gpu_process_id_; }
+  base::ProcessId gpu_process_id() const { return channel_->peer_pid(); }

[apatrick_chromium, 2012/04/10 20:00:35]

I checked the one caller of this function and I think it actually wants the host
ID rather than the PID. So this should be:

int gpu_process_id() const { return gpu_host_id_; }

The name of the function should be gpu_host_id() or similar but I'll fix that
once you've landed. I'm a bit baffled that the tests worked. My best guess is
that both the host ID and PID have the property of uniquely identifying a
GpuProcessHost object, unless a PID is recycled.

[jschuh, 2012/04/10 23:30:59]

I just corrected it and added the gpu_host_id stuff in. The dependent sandbox
patch is landed so I'm running through the trybots now.

   int client_id() const { return client_id_; }
 
  private:
@@ -180,8 +180,8 @@
   };
 
   GpuChannelHostFactory* factory_;
-  int gpu_process_id_;
   int client_id_;
+  int gpu_host_id_;
 
   State state_;