Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 9958026: Enable ui_unittests in Android build (Closed)

Created:
8 years, 8 months ago by Xianzhu
Modified:
8 years, 8 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Enable ui_unittests in Android build BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130188

Patch Set 1 #

Patch Set 2 : Add ui_unittests_disabled #

Patch Set 3 : Tested locally #

Patch Set 4 : Add again ui_unittest_disabled (lost in the last patch set) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M build/all_android.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A build/android/gtest_filter/ui_unittests_disabled View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download
M build/android/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
8 years, 8 months ago (2012-03-30 22:17:24 UTC) #1
Yaron
lgtm assuming it compiles/links and tests pass. I think this won't affect load much as ...
8 years, 8 months ago (2012-04-02 17:19:49 UTC) #2
John Grabowski
Very exciting! Can you give a swag as to how long this takes to run ...
8 years, 8 months ago (2012-04-02 18:14:17 UTC) #3
Xianzhu
(after a full build) $ rm -rf `find out -name ui_unittests` $ time goma-android-make ui_unittests ...
8 years, 8 months ago (2012-04-02 18:36:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9958026/6002
8 years, 8 months ago (2012-04-02 18:39:22 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-02 20:09:47 UTC) #6
Change committed as 130188

Powered by Google App Engine
This is Rietveld 408576698