Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 9958023: Properly handle spdy3 responses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_proxy_client_socket.cc
diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc
index 7c8b06d36f7ee9a91f4ff79078c70a9e6fbbce82..1ad6331bc189cfa544576ffab43bfd40409db1c5 100644
--- a/net/spdy/spdy_proxy_client_socket.cc
+++ b/net/spdy/spdy_proxy_client_socket.cc
@@ -473,9 +473,9 @@ int SpdyProxyClientSocket::OnResponseReceived(
return OK;
// Save the response
- int rv = SpdyHeadersToHttpResponse(response, &response_);
- if (rv == ERR_INCOMPLETE_SPDY_HEADERS)
- return rv; // More headers are coming.
+ if (!SpdyHeadersToHttpResponse(
+ response, spdy_stream_->GetProtocolVersion(), &response_))
+ return ERR_INCOMPLETE_SPDY_HEADERS;
ramant (doing other things) 2012/03/30 22:19:58 Good catch.
Ryan Hamilton 2012/03/30 22:46:02 Thanks! I managed to hit the bug when I had this
OnIOComplete(status);
return OK;

Powered by Google App Engine
This is Rietveld 408576698