net/spdy/spdy_proxy_client_socket.cc - Issue 9958023: Properly handle spdy3 responses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 9958023: Properly handle spdy3 responses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_proxy_client_socket.cc

diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc

index 7c8b06d36f7ee9a91f4ff79078c70a9e6fbbce82..1ad6331bc189cfa544576ffab43bfd40409db1c5 100644

--- a/net/spdy/spdy_proxy_client_socket.cc

+++ b/net/spdy/spdy_proxy_client_socket.cc

@@ -473,9 +473,9 @@ int SpdyProxyClientSocket::OnResponseReceived(

return OK;

// Save the response

- int rv = SpdyHeadersToHttpResponse(response, &response_);

- if (rv == ERR_INCOMPLETE_SPDY_HEADERS)

- return rv; // More headers are coming.

+ if (!SpdyHeadersToHttpResponse(

+ response, spdy_stream_->GetProtocolVersion(), &response_))

+ return ERR_INCOMPLETE_SPDY_HEADERS;

ramant (doing other things) 2012/03/30 22:19:58 Good catch.

Ryan Hamilton 2012/03/30 22:46:02 Thanks! I managed to hit the bug when I had this

OnIOComplete(status);

return OK;