Properly handle spdy3 responses.

net/spdy/spdy_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_stream.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
+#include "net/spdy/spdy_http_utils.h"
 #include "net/spdy/spdy_session.h"
 
 namespace net {
 
 NetLogSpdyStreamErrorParameter::NetLogSpdyStreamErrorParameter(
     SpdyStreamId stream_id,
     int status,
     const std::string& description)
     : stream_id_(stream_id),
       status_(status),
@@ skipping 503 matching lines @@
 
 bool SpdyStream::HasUrl() const {
   if (pushed_)
     return response_received();
   return request_.get() != NULL;
 }
 
 GURL SpdyStream::GetUrl() const {
   DCHECK(HasUrl());
 
-  if (pushed_) {
-    if (GetProtocolVersion() >= 3) {
-      return GetUrlFromHeaderBlock(response_);
-    } else {
-      // assemble from the response
-      std::string url;
-      SpdyHeaderBlock::const_iterator it;
-      it = response_->find("url");
-      if (it != (*response_).end())
-        url = it->second;
-      return GURL(url);
-    }
-  }
-
-  return GetUrlFromHeaderBlock(request_);
-}
-
-GURL SpdyStream::GetUrlFromHeaderBlock(
-    const linked_ptr<SpdyHeaderBlock>& headers) const {
-  const char* scheme_header = GetProtocolVersion() >= 3 ? ":scheme" : "scheme";
-  const char* host_header = GetProtocolVersion() >= 3 ? ":host" : "host";
-  const char* path_header = GetProtocolVersion() >= 3 ? ":path" : "path";
-
-  std::string scheme;
-  std::string host_port;
-  std::string path;
-  SpdyHeaderBlock::const_iterator it;
-  it = headers->find(scheme_header);
-  if (it != (*headers).end())
-    scheme = it->second;
-  it = headers->find(host_header);
-  if (it != (*headers).end())
-    host_port = it->second;
-  it = headers->find(path_header);
-  if (it != (*headers).end())
-    path = it->second;
-  std::string url = scheme + "://" + host_port + path;
-  return GURL(url);
+  const SpdyHeaderBlock& headers = (pushed_) ? *response_ : *request_;
+  return GetUrlFromHeaderBlock(headers, GetProtocolVersion(), pushed_);
 }
 
 void SpdyStream::OnGetDomainBoundCertComplete(int result) {
   DCHECK_EQ(STATE_GET_DOMAIN_BOUND_CERT_COMPLETE, io_state_);
   DoLoop(result);
 }
 
 int SpdyStream::DoLoop(int result) {
   do {
     State state = io_state_;
@@ skipping 211 matching lines @@
   UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime",
       recv_last_byte_time_ - recv_first_byte_time_);
   UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime",
       recv_last_byte_time_ - send_time_);
 
   UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_);
   UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_);
 }
 
 }  // namespace net