Create Linux platform app shortcuts to run in their own process.

chrome/browser/web_applications/web_app.h

Index: chrome/browser/web_applications/web_app.h
diff --git a/chrome/browser/web_applications/web_app.h b/chrome/browser/web_applications/web_app.h
index 4a6367fd7c65ece46c8d4e48f12177802a4f89e2..7fb058ef762eaac04220f3d3eb8659ca0a3f4492 100644
--- a/chrome/browser/web_applications/web_app.h
+++ b/chrome/browser/web_applications/web_app.h
@@ -46,14 +46,20 @@ std::string GenerateApplicationNameFromExtensionId(const std::string& id);
 std::string GetExtensionIdFromApplicationName(const std::string& app_name);
 
 // Creates a shortcut for web application based on given shortcut data.
-// |profile_path| is used as root directory for persisted data such as icon.
-// Directory layout is similar to what Gears has, i.e. an web application's
-// file is stored under "#/host_name/scheme_port", where '#' is the
-// |root_dir|.  A crx based app uses a directory named _crx_<app id>.
+// |profile_path| is the path of the creating profile. |shortcut_info)
+// contains information about the shortcut to create.
 void CreateShortcut(
     const FilePath& profile_path,
     const ShellIntegration::ShortcutInfo& shortcut_info);
 
+// Creates a shortcut. Must be called on the file thread. This is used to
+// implement CreateShortcut() above, and can also be used directly from the
+// file thread. |profile_path| is the path of the creating profile.
+// |shortcut_info| constains info about the shortcut to create.
+bool CreateShortcutOnFileThread(
+    const FilePath& profile_path,

[sail, 2012/04/12 15:06:29]

do you really need this? if you just call CreateShortcut things will still work
right?

[benwells, 2012/04/13 01:48:48]

This function returns success or failure, which the other one doesn't (and can't
as it is asynchronous).

[sail, 2012/04/13 01:59:14]

what's the point of returning failure?
putting up an error dialog isn't helpful unless you're adding new UI to handle
the error somehow

[benwells, 2012/04/13 02:09:02]

In the NTP there is a command to create the shortcut which shows a dialog. The
gtk version of this dialog shows an error message if the command fails instead
of silently failing.

Prior to this change it basically replicated the CreatePlatformShortcut code in
the dialog, with this change we can make it all common in web_app.cc

[sail, 2012/04/13 02:16:41]

ok

+    const ShellIntegration::ShortcutInfo& shortcut_info);
+
 // Returns true if given url is a valid web app url.
 bool IsValidUrl(const GURL& url);
 
@@ -78,11 +84,16 @@ namespace internals {
 bool CheckAndSaveIcon(const FilePath& icon_file, const SkBitmap& image);
 #endif
 
-// Does the actual job of creating a shortcut (see CreateShortcut() above).
-// This must be called on the file thread.
-void CreateShortcutTask(const FilePath& web_app_path,
-                        const FilePath& profile_path,
-                        const ShellIntegration::ShortcutInfo& shortcut_info);
+// Implemented for each platform, does the platform specific parts of creating
+// shortcuts. Used internally by CreateShortcutOnFileThread.
+// |shortcut_data_path| is where to store any resources created for the
+// shortcut, and is also used as the UserDataDir for platform app shortcuts.
+// |profile_path| is the path of the creating profile. |shortcut_info|
+// contains info about the shortcut to create.
+bool CreatePlatformShortcut(
+    const FilePath& shortcut_data_path,
+    const FilePath& profile_path,
+    const ShellIntegration::ShortcutInfo& shortcut_info);
 
 // Sanitizes |name| and returns a version of it that is safe to use as an
 // on-disk file name .