Create Linux platform app shortcuts to run in their own process.

chrome/browser/web_applications/web_app.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_applications/web_app.h"
 
 #include "base/bind.h"
+#include "base/bind_helpers.h"
 #include "base/file_util.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/string_util.h"
 #include "base/threading/thread.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
 
@@ skipping 93 matching lines @@
 }
 
 std::string GetExtensionIdFromApplicationName(const std::string& app_name) {
   std::string prefix(kCrxAppPrefix);
   if (app_name.substr(0, prefix.length()) != prefix)
     return std::string();
   return app_name.substr(prefix.length());
 }
 
 void CreateShortcut(
-    const FilePath& data_dir,
+    const FilePath& profile_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
   BrowserThread::PostTask(
       BrowserThread::FILE,
       FROM_HERE,
-      base::Bind(&internals::CreateShortcutTask,
-                 GetWebAppDataDirectory(
-                      data_dir,
-                      shortcut_info.extension_id,
-                      shortcut_info.url),
-                 data_dir,
+      base::Bind(base::IgnoreResult(&CreateShortcutOnFileThread),
+                 profile_path,
                  shortcut_info));
 }
 
+bool CreateShortcutOnFileThread(
+    const FilePath& profile_path,
+    const ShellIntegration::ShortcutInfo& shortcut_info) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+
+  FilePath shortcut_data_dir = GetWebAppDataDirectory(
+      profile_path, shortcut_info.extension_id, shortcut_info.url);
+  // Ensure shortcut_data_dir exists
+  if (!file_util::PathExists(shortcut_data_dir) &&
+      !file_util::CreateDirectory(shortcut_data_dir)) {

[sail, 2012/04/12 15:06:29]

is this really necessary? on the Mac the data directory is created by Chrome at
startup. Maybe we can fix the chrome startup code instead?

[benwells, 2012/04/13 01:48:48]

Yes, some files are put in this folder at shortcut creation time. We could leave
this in each platform specific section but it felt good to make it common.

[sail, 2012/04/13 01:59:14]

ok

+    return false;
+  }
+  return internals::CreatePlatformShortcut(
+      shortcut_data_dir, profile_path, shortcut_info);
+}
+
 bool IsValidUrl(const GURL& url) {
   static const char* const kValidUrlSchemes[] = {
       chrome::kFileScheme,
       chrome::kFtpScheme,
       chrome::kHttpScheme,
       chrome::kHttpsScheme,
       chrome::kExtensionScheme,
   };
 
   for (size_t i = 0; i < arraysize(kValidUrlSchemes); ++i) {
@@ skipping 23 matching lines @@
 
 #if defined(TOOLKIT_USES_GTK)
 std::string GetWMClassFromAppName(std::string app_name) {
   file_util::ReplaceIllegalCharactersInPath(&app_name, '_');
   TrimString(app_name, "_", &app_name);
   return app_name;
 }
 #endif
 
 }  // namespace web_app