Create Linux platform app shortcuts to run in their own process.

chrome/browser/shell_integration.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
 #pragma once
 
 #include <string>
 
@@ skipping 101 matching lines @@
 
   // Set up command line arguments for launching a platform app.
   // The command line will have the switches --app-id, --user-data-dir and
   // --load-extension, using values |extension_app_id|, |user_data_dir| and
   // |extension_path| respectively.
   static CommandLine CommandLineArgsForPlatformApp(
       const std::string& extension_app_id,
       const FilePath& user_data_dir,
       const FilePath& extension_path);
 
 #if defined(USE_X11)

[sail, 2012/04/12 15:06:29]

could you move this to shell_integration_linux.h? Since these are just statics
you probably don't need them to be a part of the ShortcutInfo struct.

[benwells, 2012/04/13 01:48:48]

They're part of the ShellIntegration class, not the ShortcutInfo struct. The
ShellIntegration class is more of a namespace than a class.

I guess we could convert it to a namespace and split out all the platform
specific stuff into separate headers, but that's orthogonal.

[sail, 2012/04/13 01:59:14]

Sorry, I mistook which struct this was in. Regardless. Adding more #ifdefed out
code is bad. Putting it in the platform specific header is better.

[benwells, 2012/04/13 02:09:02]

Agreed. There are currently no platform specific headers. I could create them
and move the platform specific stuff in there, in the process converting from a
class to a namespace, but that feels orthogonal to this change.

[sail, 2012/04/13 02:16:41]

You don't have to move everything. Just create a new namespace
ShellIntegrationX11 and add the new function in that.

[benwells, 2012/04/13 04:55:30]

OK. I've moved just the new function. Let me know if you had something else in
mind.

It feels good like this but the rest of these X11 functions should also move out
(and probably the windows stuff too for consistency), but I'd like to do that as
a separate change to keep the changes manageable and reviewable.

While I'm cleaning it up it might make sense to change ShellIntegration from a
class to a namespace. Its all static except IsRunningInAppMode which doesn't
appear to be used anywhere. Is there any reason to leave it as a class?

   // Returns filename of the desktop shortcut used to launch the browser.
   static std::string GetDesktopName(base::Environment* env);
 
   static bool GetDesktopShortcutTemplate(base::Environment* env,
                                          std::string* output);
 
   // Returns filename for .desktop file based on |url|, sanitized for security.
   static FilePath GetDesktopShortcutFilename(const GURL& url);
 
   // Returns contents for .desktop file based on |template_contents|, |url|
   // and |title|. The |template_contents| should be contents of .desktop file
   // used to launch Chrome.
   static std::string GetDesktopFileContents(
       const std::string& template_contents,
       const std::string& app_name,
       const GURL& url,
       const std::string& extension_id,
+      const bool is_platform_app,
+      const FilePath& web_app_path,
+      const FilePath& extension_path,
       const string16& title,
       const std::string& icon_name);
 
-  static void CreateDesktopShortcut(const ShortcutInfo& shortcut_info,
+  static bool CreateDesktopShortcut(const ShortcutInfo& shortcut_info,
                                     const std::string& shortcut_template);
+
+  static bool CreateDesktopShortcutForChromeApp(
+      const ShortcutInfo& shortcut_info,
+      const FilePath& web_app_path,
+      const std::string& shortcut_template);
 #endif  // defined(USE_X11)
 
 #if defined(OS_WIN)
   // Generates Win7 app id for given app name and profile path. The returned app
   // id is in the format of "|app_name|[.<profile_id>]". "profile_id" is
   // appended when user override the default value.
   static string16 GetAppId(const string16& app_name,
                            const FilePath& profile_path);
 
   // Generates Win7 app id for Chromium by calling GetAppId with
@@ skipping 138 matching lines @@
     // Set Chrome as the default handler for this protocol.
     virtual void SetAsDefault() OVERRIDE;
 
     std::string protocol_;
 
     DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker);
   };
 };
 
 #endif  // CHROME_BROWSER_SHELL_INTEGRATION_H_