Chromium Code Reviews| Index: chrome/browser/ui/gtk/browser_titlebar.h |
| diff --git a/chrome/browser/ui/gtk/browser_titlebar.h b/chrome/browser/ui/gtk/browser_titlebar.h |
| index 9c490f3c8ff5dd9ad7235f747de2321d15f22929..0b92632463f55621fff30e1898f07d54683ff6c7 100644 |
| --- a/chrome/browser/ui/gtk/browser_titlebar.h |
| +++ b/chrome/browser/ui/gtk/browser_titlebar.h |
| @@ -74,24 +74,20 @@ class BrowserTitlebar : public content::NotificationObserver, |
| // add to the menu. |
| void ShowContextMenu(GdkEventButton* event); |
| - // When a panel slides into a new position and the cursor is on the close |
| - // button, the close button does not become clickable. The gtk_widget_show() |
| - // call on panel_wrench_button_ in OnEnterNotify on window_ prevents the |
| - // close_button_ from getting the enter-notify-event, making it unclickable. |
| - // This creates a bad experience when a user has multiple panels of the same |
| - // size (which is typical) and tries closing them all by repeatedly clicking |
| - // in the same place on the screen. |
| - // |
| - // Opened a gtk bug for this - |
| - // https://bugzilla.gnome.org/show_bug.cgi?id=667841 |
| - void SendEnterNotifyToCloseButtonIfUnderMouse(); |
| + // When a panel slides into a new position and the cursor is on the close |
| + // button, the close button does not become clickable. Neither of |
|
Evan Stade
2012/04/16 19:23:48
grammar
jianli
2012/04/16 23:24:45
Done.
|
| + // "enter-notify-event" or "clicked" event on the mouse does not fire. |
| + // This creates a bad experience when a user has multiple panels of the same |
| + // size (which is typical) and tries closing them all by repeatedly clicking |
| + // in the same place on the screen. |
| + // |
| + // Opened a gtk bug for this - |
| + // https://bugzilla.gnome.org/show_bug.cgi?id=667841 |
| + void SendEnterNotifyToCloseButtonIfUnderMouse(); |
|
jennb
2012/04/16 21:17:05
Is this still needed now that there's no wrench bu
jianli
2012/04/16 23:24:45
Yes, it is still needed. Update comment to make it
|
| // Returns the window width to display just the icon. |
| int IconOnlyWidth(); |
| - void ShowPanelWrenchButton(); |
| - void HidePanelWrenchButton(); |
| - |
| AvatarMenuButtonGtk* avatar_button() { return avatar_button_.get(); } |
| private: |
| @@ -175,8 +171,6 @@ class BrowserTitlebar : public content::NotificationObserver, |
| // Callback for favicon/settings buttons. |
| CHROMEGTK_CALLBACK_1(BrowserTitlebar, gboolean, |
| OnFaviconMenuButtonPressed, GdkEventButton*); |
| - CHROMEGTK_CALLBACK_1(BrowserTitlebar, gboolean, |
| - OnPanelSettingsMenuButtonPressed, GdkEventButton*); |
| // -- Context Menu ----------------------------------------------------------- |
| @@ -249,10 +243,6 @@ class BrowserTitlebar : public content::NotificationObserver, |
| GtkWidget* app_mode_favicon_; |
| GtkWidget* app_mode_title_; |
| - // Wrench icon for panels. This'll only appear when a panel window has focus |
| - // or mouse is in a panel window. |
| - scoped_ptr<CustomDrawButton> panel_wrench_button_; |
| - |
| // Whether we are using a custom frame. |
| bool using_custom_frame_; |