Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 9956140: Add very minimum IBus-1.5 support to InputMethodManager (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add very minimum IBus-1.5 support to InputMethodManager. BUG=chromium-os:27832 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132172

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
kinaba: Since the huge IME refactoring patch (part 6 of 6) only works fine with ...
8 years, 8 months ago (2012-04-13 05:41:43 UTC) #1
kinaba
http://codereview.chromium.org/9956140/diff/4001/chrome/browser/chromeos/input_method/input_method_manager.cc File chrome/browser/chromeos/input_method/input_method_manager.cc (right): http://codereview.chromium.org/9956140/diff/4001/chrome/browser/chromeos/input_method/input_method_manager.cc#newcode781 chrome/browser/chromeos/input_method/input_method_manager.cc:781: ibus_controller_->ChangeInputMethod(*engine_iter); You mean value.string_list_value[0]? The vector is already rotated ...
8 years, 8 months ago (2012-04-13 06:16:50 UTC) #2
kinaba
LGTM on patch set 2, and the plan in the first comment.
8 years, 8 months ago (2012-04-13 08:22:17 UTC) #3
Yusuke Sato
http://codereview.chromium.org/9956140/diff/4001/chrome/browser/chromeos/input_method/input_method_manager.cc File chrome/browser/chromeos/input_method/input_method_manager.cc (right): http://codereview.chromium.org/9956140/diff/4001/chrome/browser/chromeos/input_method/input_method_manager.cc#newcode781 chrome/browser/chromeos/input_method/input_method_manager.cc:781: ibus_controller_->ChangeInputMethod(*engine_iter); On 2012/04/13 06:16:50, kinaba wrote: > You mean ...
8 years, 8 months ago (2012-04-13 09:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9956140/5002
8 years, 8 months ago (2012-04-13 09:37:48 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 11:02:26 UTC) #6
Change committed as 132172

Powered by Google App Engine
This is Rietveld 408576698