Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 9956060: Check code kind when resetting profiler ticks. (Closed)

Created:
8 years, 8 months ago by ulan
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Check code kind when resetting profiler ticks. BUG=121147 TEST=chromium gpu_tests/WebGLConformanceTests Committed: https://code.google.com/p/v8/source/detail?r=11208

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/objects.cc View 1 chunk +9 lines, -6 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
This LGTM, although I am probably no the right one to review this. Erik, could ...
8 years, 8 months ago (2012-04-02 12:43:39 UTC) #1
ulan
https://chromiumcodereview.appspot.com/9956060/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/9956060/diff/1/src/objects.cc#newcode7873 src/objects.cc:7873: if (code()->kind() == Code::FUNCTION) { Another kind that can ...
8 years, 8 months ago (2012-04-02 12:52:29 UTC) #2
Erik Corry
8 years, 8 months ago (2012-04-02 13:15:19 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698