ash: Add accelerator for snapping windows left/right.

ash/accelerators/accelerator_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_table.h"
 
 #include "base/basictypes.h"
 
 namespace ash {
 
@@ skipping 53 matching lines @@
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_VOLUME_MUTE, false, false, false,
     VOLUME_MUTE },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_F9, false, false, false,
     VOLUME_DOWN },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_VOLUME_DOWN, false, false, false,
     VOLUME_DOWN },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_F10, false, false, false, VOLUME_UP },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_VOLUME_UP, false, false, false,
     VOLUME_UP },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_S, true, false, true, FOCUS_TRAY },
+  { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_LEFT, false, true, true,

[Daniel Erat, 2012/04/17 16:51:19]

it has been asserted in the past (by pkasting, i think) that we should stay away
from ctrl-alt accelerators.  i think they conflict with certain accelerators for
entering non-latin characters, although perhaps only on other OSes.

also, these are weird since i believe that we remap alt-up/down to page up/down
and ctrl-alt-up/down to home/end on chromebooks.  it's best to stay as far away
from that mess as possible.

i used alt-comma and alt-period for similar actions in the old X window manager.
 any reason that those, or their ctrl- equivalents, couldn't be used here
instead?

[sadrul, 2012/04/25 16:04:21]

I changed the bindings to the ones suggested in the bug (alt- []-=+)

+    SNAP_WINDOW_LEFT },
+  { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_RIGHT, false, true, true,
+    SNAP_WINDOW_RIGHT },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_F1, true, true, false, SHOW_OAK },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_1, false, false, true,
     SELECT_WIN_0 },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_2, false, false, true,
     SELECT_WIN_1 },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_3, false, false, true,
     SELECT_WIN_2 },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_4, false, false, true,
     SELECT_WIN_3 },
   { ui::ET_TRANSLATED_KEY_PRESS, ui::VKEY_5, false, false, true,
@@ skipping 49 matching lines @@
   PRINT_LAYER_HIERARCHY,
   PRINT_WINDOW_HIERARCHY,
   ROTATE_SCREEN,
 #endif
 };
 
 const size_t kActionsAllowedAtLoginScreenLength =
     arraysize(kActionsAllowedAtLoginScreen);
 
 }  // namespace ash