Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/automation/automation_provider_observers.h

Issue 9950098: Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of message… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Found a use where this change broke ExecuteJavascript, this should fix it. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider_observers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider_observers.h
diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h
index de14843d268275aab75c0e71ec549583c720fd32..e1f2bda5a0d3ee60f05a6d0c0a829a9b21113b85 100644
--- a/chrome/browser/automation/automation_provider_observers.h
+++ b/chrome/browser/automation/automation_provider_observers.h
@@ -608,7 +608,7 @@ class FindInPageNotificationObserver : public content::NotificationObserver {
class DomOperationObserver : public content::NotificationObserver {
public:
- DomOperationObserver();
+ explicit DomOperationObserver(int automation_id);
virtual ~DomOperationObserver();
virtual void Observe(int type,
@@ -620,6 +620,7 @@ class DomOperationObserver : public content::NotificationObserver {
virtual void OnJavascriptBlocked() = 0;
private:
+ int automation_id_;
content::NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(DomOperationObserver);
@@ -630,7 +631,7 @@ class DomOperationObserver : public content::NotificationObserver {
class DomOperationMessageSender : public DomOperationObserver {
public:
DomOperationMessageSender(AutomationProvider* automation,
- IPC::Message* relpy_message,
+ IPC::Message* reply_message,
bool use_json_interface);
virtual ~DomOperationMessageSender();
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider_observers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698